[trie] Introduce GenericTrieNode as replacement of GenericUpdatedTrieNode

[shreyan-gupta]

This PR introduces the GenericTrieNode which is a generalization on top of GenericUpdatedTrieNode where the nodes need not be an update type node.

This is useful in scenarios where we are not dealing with just updates, for example generalizing iterators over tries etc.

Along with this change this PR renames GenericUpdatedNodeId to UpdatedNodeId which is more appropriate as for both memtries and store tries we have UpdatedNodeId as usize.

[codecov]

Codecov Report

Attention: Patch coverage is 93.54839% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.85%. Comparing base (9e4933b) to head (e8ee3b4).
Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
core/store/src/trie/mod.rs	66.66%	3 Missing ⚠️
core/store/src/trie/ops/interface.rs	92.30%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #12496      +/-   ##
==========================================
+ Coverage   69.84%   69.85%   +0.01%     
==========================================
  Files         838      838              
  Lines      169410   169429      +19     
  Branches   169410   169429      +19     
==========================================
+ Hits       118323   118356      +33     
+ Misses      45840    45820      -20     
- Partials     5247     5253       +6     

Flag	Coverage Δ
backward-compatibility	0.16% <0.00%> (-0.01%)	⬇️
db-migration	0.16% <0.00%> (-0.01%)	⬇️
genesis-check	1.29% <0.00%> (-0.01%)	⬇️
linux	69.16% <93.54%> (-0.01%)	⬇️
linux-nightly	69.43% <93.54%> (+<0.01%)	⬆️
macos	51.02% <93.54%> (+0.01%)	⬆️
pytests	1.60% <0.00%> (-0.01%)	⬇️
sanity-checks	1.40% <0.00%> (-0.01%)	⬇️
unittests	69.68% <93.54%> (+0.01%)	⬆️
upgradability	0.21% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Longarithm]

Wow, this is great.
Once we get rid of old trie node structs, can we remove the prefix "Generic" from structs? This word doesn't tell anything because <> already show that struct is generic.

[shreyan-gupta]

Wow, this is great. Once we get rid of old trie node structs, can we remove the prefix "Generic" from structs? This word doesn't tell anything because <> already show that struct is generic.

Yes, will do once we can remove the current version of trie nodes.