feat: stabilize NEP 492 #9658
feat: stabilize NEP 492 #9658
Conversation
There was a problem hiding this comment.
LGTM. Left one comment regarding the changelog entry.
As a general note, when stabilizing a protocol feature, the PR itself is usually very simple but it is nevertheless a crucial change. Therefore, I love it when the PR author describes what testing has ben done and why it's ready to be stabilized. It usually only takes 30s to write it in the commit message but potentially saves the reviewers much more time.
Of course, in this case, for me, I already have all the context. But adding this information makes it more accessible for anybody else.
For example:
- The NEP has been officially approved in September (proposal to restrict ethereum address on NEAR NEPs#492 (comment)).
- feat(runtime): restrict creation of non-implicit TLA #9589 implements the feature and includes tests checking that TLA can no longer be created in the new protocol version.
Looking at https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review, I see the following: """ So the simple answer is that @ jakmeier does not have read access to the repo. Not sure if github allows giving the world read access. It does not appear that this is possible. https://github.com/near/nearcore/settings/access?query= shows who has what kind of access to the repo currently. I will start an internal thread to discuss making changes here. |
bowenwang1996
force-pushed
the
stabilize-restrict-tla
branch
from
550fa4b
to
11e3743
Compare
|
For what it's worth, tagging me in a comment will do the same for me as adding me as reviewer. Both will show up as GH notification and I will take a look. |
Stabilize near/NEPs#492. Restrict the creation of non-implicit top-level account that are longer than 32 bytes. Only the registrar account can create them. More context on the proposal: - The NEP has been officially approved in September (near/NEPs#492 (comment)). - #9589 implements the feature and includes tests checking that TLA can no longer be created in the new protocol version.
ghost
mentioned this pull request
ghost
mentioned this pull request
near#9658 stabilized a protocol feature that restricts creating top level accounts unless you're the registrar, and in this test we were trying to create one. change it to be a subaccount of the tx signer
#9658 stabilized a protocol feature that restricts creating top level accounts unless you're the registrar, and in this test we were trying to create one. change it to be a subaccount of the tx signer
Stabilize near/NEPs#492. Restrict the creation of non-implicit top-level account that are longer than 32 bytes. Only the registrar account can create them. More context on the proposal: