fix: fastify version mismatch #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanbirrell
commented
Oct 24, 2024
| @@ -6,8 +6,6 @@ | |||
| "test": "c8 tap --no-cov" | |||
| }, | |||
| "dependencies": { | |||
| "fastify": "^4.28.1", | |||
| "mercurius": "^14.1.0", | |||
There was a problem hiding this comment.
These two were already installed in the workspace root. Better to avoid potential for duplicate versions in the future and centralize to the root package.json.
There was a problem hiding this comment.
yep agreed. hopefully there wasn't a reason why they were installed in the individual workspaces. thanks for catching it
nathanbirrell
commented
Oct 24, 2024
| "db:migrate": "postgrator", | ||
| "db:down": "docker-compose down", | ||
| "db:down": "docker compose down", |
There was a problem hiding this comment.
Updated docker-compose syntax, to align with the fastify-workshop
simoneb
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #701
This should fix the test failures in CI too.