Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Gradle's build in warning mode failure #120

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use Gradle's build in warning mode failure #120

wants to merge 3 commits into from

Conversation

DanielThomas
Copy link
Contributor

@DanielThomas DanielThomas commented Jan 22, 2020 •
edited
Loading

Warning mode has had a fail option since Gradle 5.6. This switches to the property, allows the warning mode to be configured and removes our implementation that's always liable to break with new releases.

chali
chali reviewed Jan 22, 2020
View reviewed changes
Copy link
Member

@chali chali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you could add an easy way to override value? A bunch of our tests is using system property to ignore warnings or passing different level through command-line arguments. Having an ability to override it per test would be awesome.

@DanielThomas DanielThomas changed the title Warning mode is now a first class option Switch to Gradle --warning-mode argument, failing by default Jan 31, 2020
@DanielThomas
Copy link
Contributor Author

Looks like this'll break cross-version testing. Let me work on this some more.

@DanielThomas DanielThomas changed the title Switch to Gradle --warning-mode argument, failing by default Use Gradle's build in warning mode failure Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chali chali chali left review comments

@OdysseusLives OdysseusLives OdysseusLives approved these changes

@rpalcolea rpalcolea rpalcolea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielThomas @chali @rpalcolea @OdysseusLives