Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI integration #88

Open
vemv opened this issue Aug 21, 2019 · 1 comment
Open

CI integration #88

vemv opened this issue Aug 21, 2019 · 1 comment
Labels

Comments

@vemv
Copy link
Contributor

vemv commented Aug 21, 2019

Context

It is desirable that PRs are already formatted and comply with the linters.

Task

Implement a CLI task that formats/lints stuff, failing the CI build when stuff is wrong.

Acceptance criteria

  • formatters should have a dry-run option
  • formatters should return ok?
  • linters should return ok?
  • an invokable f-s.ci/-main function should be offered
@vemv vemv added the core label Aug 21, 2019
thumbnail added a commit that referenced this issue Oct 21, 2019
thumbnail added a commit that referenced this issue Oct 21, 2019
thumbnail added a commit that referenced this issue Oct 22, 2019
thumbnail added a commit that referenced this issue Oct 22, 2019
thumbnail added a commit that referenced this issue Oct 22, 2019
thumbnail added a commit that referenced this issue Oct 22, 2019
thumbnail added a commit that referenced this issue Oct 22, 2019
thumbnail added a commit that referenced this issue Oct 22, 2019
thumbnail added a commit that referenced this issue Dec 20, 2019
thumbnail added a commit that referenced this issue Dec 20, 2019
thumbnail added a commit that referenced this issue Dec 20, 2019
@thumbnail
Copy link
Member

As noted in #93, this issue is best to be picked up after the reporter is available for the whole stack.

This issue could be implemented initially for just the linters, adding the formatters after #110 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants