Skip to content

Commit

Permalink
test: add regression test for path w/ trailing wildcard
Browse files Browse the repository at this point in the history
We decided to leave trailing `*` meaning the same as `**` because it was
already in use.

Original description:

This patch demonstrates a corner case in the path glob matcher.
Specifically, it documents how a single trailing asterisk is supposed
to be treated as opposed to a double asterisk.
With [[1]], a trailing `/*` is interpreted as an equivalent of `/**`.
The commit add a case that shows that `/*` shouldn't be greedy as
described in the docs [[2]][[3]].

See also the observations in the bug report ticket [[4]].

[1]: ec6205a
[2]: https://coverage.rtfd.io/en/stable/source.html#file-patterns
[3]: https://coverage.rtfd.io/en/7.2.7/migrating.html#migrating-to-coverage-py-7-x
[4]: #1407 (comment)
  • Loading branch information
webknjaz authored and nedbat committed Aug 29, 2023
1 parent f0c18f6 commit df8d143
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tests/test_files.py
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@ def test_glob_matcher(self) -> None:
(self.make_file("sub/file1.py"), True),
(self.make_file("sub/file2.c"), False),
(self.make_file("sub2/file3.h"), True),
(self.make_file("sub2/sub/file3.h"), True),
(self.make_file("sub3/file4.py"), True),
(self.make_file("sub3/file5.c"), False),
]
Expand Down

0 comments on commit df8d143

Please sign in to comment.