Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore selection in contentEditable #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Restore selection in contentEditable #45

wants to merge 2 commits into from

Conversation

tje3d
Copy link

@tje3d tje3d commented May 6, 2018

execCommand in replaceText wont trigger mouseup or keyup and that's why we lose caret

Closes #39

@tje3d tje3d mentioned this pull request May 6, 2018
Open
@g-viet
Copy link

g-viet commented May 24, 2018

👍 I got stuck into this bug. Thank you !

@g-viet g-viet mentioned this pull request May 25, 2018
Open
@g-viet
Copy link

g-viet commented May 25, 2018

ref tje3d#1

@g-viet
Copy link

g-viet commented May 25, 2018

@tje3d It does not work in Safari.
In Safari, I guess when focus event is triggered, window.getSelection() take no range, window.r angeCount = 0, then it can not update range.

@g-viet g-viet mentioned this pull request Jun 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tje3d @g-viet