Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reasoning for security zones #68

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Conversation

lilachic
Copy link
Contributor

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Code cleanup
  • Build system change
  • [ x ] Documentation change
  • Language translation

Pull request long description:

Add content to document section Local security / zone considerations

Changes made:

Related issues:

Additional information:

Release note:

Documentation change:

Mentions:

docs/guides/deploy-k8s.md Outdated Show resolved Hide resolved
@lilachic lilachic marked this pull request as ready for review November 23, 2023 12:16
@lilachic lilachic requested a review from a team November 23, 2023 12:17
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this level of description, though might be good to get other opinions to see if we need to go into depth with diagrams of anything else

@blankdots blankdots requested a review from a team November 23, 2023 16:14
docs/guides/deploy-k8s.md Outdated Show resolved Hide resolved
docs/guides/deploy-k8s.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pontus pontus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added some language suggestions, feel free to disregard them if you prefer.

@lilachic
Copy link
Contributor Author

If no more changes is asked this is ready to be merged.

Just do notice, anyone did not comment about "- Differences in deployment make concrete examples challenges, explain what can be exemplified and what not in this guide" line at the beginning, I kept it as guideline and forgot to remove.

Now I changed it to be more aligned with rest of the text "Differences in deployment make concrete examples challenging, here it is explained only the guidelines."

@pontus pontus merged commit 25f557f into master Nov 27, 2023
3 checks passed
@pontus pontus deleted the docs/fill-security-section-to-guide branch November 27, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants