-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add reasoning for security zones #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this level of description, though might be good to get other opinions to see if we need to go into depth with diagrams of anything else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added some language suggestions, feel free to disregard them if you prefer.
If no more changes is asked this is ready to be merged. Just do notice, anyone did not comment about "- Differences in deployment make concrete examples challenges, explain what can be exemplified and what not in this guide" line at the beginning, I kept it as guideline and forgot to remove. Now I changed it to be more aligned with rest of the text "Differences in deployment make concrete examples challenging, here it is explained only the guidelines." |
Describe the pull request:
Pull request long description:
Add content to document section Local security / zone considerations
Changes made:
Related issues:
Additional information:
Release note:
Documentation change:
Mentions: