Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links #76

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Fix broken links #76

merged 6 commits into from
Dec 4, 2023

Conversation

viklund
Copy link
Member

@viklund viklund commented Nov 28, 2023

Describe the pull request:

  • Build system change
  • Documentation change

Pull request long description:

  • Add s3inbox to the collected information in the json
  • Update broken links so they work
  • Upgrade some links to go to https instead of http where https exists.

@viklund viklund requested a review from blankdots November 28, 2023 10:20
@viklund viklund changed the title Hackathon/from the viklund Fix broken links Nov 28, 2023
blankdots
blankdots suggested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please leave the sda.md changes for the https://github.com/neicnordic/sensitive-data-archive

docs/services/sda.md Outdated Show resolved Hide resolved
@blankdots blankdots mentioned this pull request Nov 28, 2023
Merged
@blankdots blankdots force-pushed the hackathon/from-the-viklund branch from 2c04e9b to b6952ac Compare December 1, 2023 09:43
@blankdots blankdots requested review from blankdots and a team December 1, 2023 09:43
@blankdots blankdots requested a review from a team December 1, 2023 09:44
kjellp
kjellp approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@kjellp kjellp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blankdots blankdots merged commit 317148b into master Dec 4, 2023
3 checks passed
@blankdots blankdots deleted the hackathon/from-the-viklund branch December 4, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjellp kjellp kjellp approved these changes

@blankdots blankdots blankdots approved these changes

Assignees

@viklund viklund

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viklund @blankdots @kjellp