-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/bugs rephrasing hacakathon #79
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankdots
force-pushed
the
docs/bugs-rephrasing-hacakathon
branch
from
November 28, 2023 14:49
b169d3e
to
052076c
Compare
kjellp
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, very nice round of clean up!
blankdots
force-pushed
the
docs/bugs-rephrasing-hacakathon
branch
from
November 29, 2023 15:37
26d94e0
to
f1fbf8a
Compare
aaperis
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor corrections
- use stand-alone - use SSH and SFTP - ingestion does not re-encrypt with a new key
- match components with figure
Co-authored-by: Alex Aperis <[email protected]>
blankdots
force-pushed
the
docs/bugs-rephrasing-hacakathon
branch
from
December 1, 2023 09:35
2fe2d67
to
8e45ac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
Changes made:
changes based on this, leaving out new additions or big changes
https://docs.google.com/document/d/13bHYYNRbFYHO05WN7rrXjB7reiIHmM1_Mp5WRAEGPu0/edit
The focus was on typo fixing and rephrasing.
Related issues:
Additional information:
Release note:
Documentation change:
Mentions: