Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use reference id for exporting data #316

Merged
merged 3 commits into from
Nov 22, 2024
Merged

use reference id for exporting data #316

merged 3 commits into from
Nov 22, 2024

Conversation

Parisa68
Copy link
Contributor

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Unit/integration tests
  • Code cleanup
  • Build system change
  • Documentation change

Pull request long description:

Related issues:

Additional information:

@Parisa68 Parisa68 marked this pull request as draft October 31, 2024 07:54
@Parisa68 Parisa68 marked this pull request as ready for review November 20, 2024 12:39
@Parisa68 Parisa68 requested a review from kjellp November 20, 2024 12:40
kjellp
kjellp approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@kjellp kjellp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice:) LGTM and test works in TSD.

@Parisa68 Parisa68 merged commit 93ebe1e into master Nov 22, 2024
3 of 4 checks passed
@Parisa68 Parisa68 deleted the using-refrence-id-for-export branch November 22, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjellp kjellp kjellp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Parisa68 @kjellp