pass nil as the jsonBody for the dataset release function

neicnordic · Sep 18, 2024 · 95c6bf9 · 95c6bf9
1 parent ae67160
commit 95c6bf9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/sda-admin/dataset/dataset.go b/sda-admin/dataset/dataset.go
@@ -48,9 +48,7 @@ func Release(apiURI, token, datasetID string) error {
 	}
 	parsedURL.Path = path.Join(parsedURL.Path, "dataset/release") + "/" + datasetID
 
-	jsonBody := []byte("{}")
-	_, err = helpers.PostRequest(parsedURL.String(), token, jsonBody)
-
+	_, err = helpers.PostRequest(parsedURL.String(), token, nil)
 	if err != nil {
 		return err
 	}

diff --git a/sda-admin/dataset/dataset_test.go b/sda-admin/dataset/dataset_test.go
@@ -67,9 +67,8 @@ func TestRelease_Success(t *testing.T) {
 
 	expectedURL := "http://example.com/dataset/release/dataset-123"
 	token := "test-token"
-	jsonBody := []byte(`{}`)
 
-	mockHelpers.On("PostRequest", expectedURL, token, jsonBody).Return([]byte(`{}`), nil)
+	mockHelpers.On("PostRequest", expectedURL, token, []byte(nil)).Return([]byte(`{}`), nil)
 
 	err := Release("http://example.com", token, "dataset-123")
 	assert.NoError(t, err)
@@ -84,9 +83,8 @@ func TestRelease_PostRequestFailure(t *testing.T) {
 
 	expectedURL := "http://example.com/dataset/release/dataset-123"
 	token := "test-token"
-	jsonBody := []byte(`{}`)
 
-	mockHelpers.On("PostRequest", expectedURL, token, jsonBody).Return([]byte(nil), errors.New("failed to send request"))
+	mockHelpers.On("PostRequest", expectedURL, token, []byte(nil)).Return([]byte(nil), errors.New("failed to send request"))
 
 	err := Release("http://example.com", token, "dataset-123")
 	assert.Error(t, err)