Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last commit to sync with the old SDA-DOA repo #1187

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

Parisa68
Copy link
Contributor

Last commit to sync with the old repo. contains:

  • use reference id for exporting data
  • Change crypt4gh and clearinghouse settings to use fega-norway repo
  • rename vars to increase readability map the datasets with reference to datasets stable id
  • Handle the cases where the visas are a mix of Fega and non-fega visas
  • add tests for dataset reference
  • add tests for visa token

Related issue(s):

#901
.

Description

How to test

Copy link
Contributor

@kjellp kjellp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Parisa68 Parisa68 changed the title Last commit to sync with the old repo. contains: Last commit to sync with the old SDA-DOA repo Dec 12, 2024
- use reference id for exporting data
- Change crypt4gh and clearinghouse settings to use fega-norway repo
- rename vars ro increase readability
map the datasets with reference to datasets stable id
- Handle the cases where the visas are a mix of Fega and non-fega visas
- add tests for dataset reference
- add tests for visa token
@Parisa68 Parisa68 added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 0a8c9a5 Jan 8, 2025
23 checks passed
@Parisa68 Parisa68 deleted the last-sync-sda-doa branch January 8, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants