Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add search on notes and filename for csv tasks #137

Merged
merged 2 commits into from
Nov 13, 2024
Merged

feat: add search on notes and filename for csv tasks #137

merged 2 commits into from
Nov 13, 2024

Conversation

tehreem-sadat
Copy link
Collaborator

@tehreem-sadat tehreem-sadat commented Nov 13, 2024 •
edited by shadinaif
Loading

Added search on notes and filename

GET /api/fx/export/v1/tasks/?search_text=abc

It will return result where notes, filename contain 'abc'

@shadinaif shadinaif force-pushed the tehreem/feat_csv_task_add_search branch from 0d7fa48 to f37cdb3 Compare November 13, 2024 12:52
shadinaif
shadinaif approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@shadinaif shadinaif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the search param to make it similar to all other APIs

@shadinaif shadinaif merged commit 4e1b311 into main Nov 13, 2024
3 checks passed
@shadinaif shadinaif deleted the tehreem/feat_csv_task_add_search branch November 13, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadinaif shadinaif shadinaif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tehreem-sadat @shadinaif