fix: Fix issues reported by PHPStan (#1225)

nelmio · Nov 12, 2024 · 1379edd · 1379edd
1 parent 3ccf859
commit 1379edd
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/...der/Denormalizer/Fixture/SpecificationBagDenormalizer/Constructor/FactoryDenormalizer.php b/...der/Denormalizer/Fixture/SpecificationBagDenormalizer/Constructor/FactoryDenormalizer.php
@@ -40,10 +40,9 @@ public function denormalize(
         FlagParserInterface $parser,
         array $unparsedMethod
     ): MethodCallInterface {
-        /** @var string|bool $method */
         $method = key($unparsedMethod);
 
-        if (false === $method
+        if (null === $method
             || false === is_string($method)
             || 1 !== count($unparsedMethod)
         ) {

diff --git a/tests/Definition/MethodCall/ConfiguratorMethodCallTest.php b/tests/Definition/MethodCall/ConfiguratorMethodCallTest.php
@@ -39,15 +39,13 @@ public function testReadAccessorsReturnPropertiesValues(): void
         $caller = new InstantiatedReference('user.factory');
         $method = 'setUsername';
         $arguments = [new stdClass()];
-        $percentage = 30;
         $stringValue = 'user.factory->setUsername';
 
         $methodCallProphecy = $this->prophesize(MethodCallInterface::class);
         $methodCallProphecy->getCaller()->willReturn($caller);
         $methodCallProphecy->getMethod()->willReturn($method);
         $methodCallProphecy->getArguments()->willReturn($arguments);
         $methodCallProphecy->__toString()->willReturn($stringValue);
-        /** @var MethodCallInterface $caller */
         $methodCall = $methodCallProphecy->reveal();
 
         $definition = new ConfiguratorMethodCall($methodCall);

diff --git a/tests/Definition/MethodCall/OptionalMethodCallTest.php b/tests/Definition/MethodCall/OptionalMethodCallTest.php
@@ -48,7 +48,6 @@ public function testReadAccessorsReturnPropertiesValues(): void
         $methodCallProphecy->getMethod()->willReturn($method);
         $methodCallProphecy->getArguments()->willReturn($arguments);
         $methodCallProphecy->__toString()->willReturn($stringValue);
-        /** @var MethodCallInterface $caller */
         $methodCall = $methodCallProphecy->reveal();
 
         $flag = new OptionalFlag($percentage);