Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable too-many-positional-arguments check #199

Merged
merged 4 commits into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,6 @@ jobs:
- script: test
test_local_var: test local var val
test_args: --test-arg --test-arg
- script: remote
remote-id: 0
- script: remote-test
coverage-name: remote-test
remote-id: 1
- script: test-coverage
test_local_var: test local var val
test_args: --test-arg
Expand All @@ -72,7 +67,6 @@ jobs:
SSH_KEY: ${{ secrets.SSH_KEY }}
SSH_CONFIG: ${{ secrets.SSH_CONFIG }}
TEST_ARGS: ${{ matrix.test_args }}
JOB_SUFFIX: ${{ matrix.remote-id }}
GH_TOKEN: ${{ secrets.PUBLIC_GH_TOKEN }}
steps:
- uses: actions/checkout@v4
Expand All @@ -98,6 +92,7 @@ jobs:
with:
name: coverage-${{ matrix.coverage-name }}
path: nengo-bones/.coverage
include-hidden-files: true
coverage:
if: ${{ always() }}
needs:
Expand Down
16 changes: 0 additions & 16 deletions .nengobones.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,22 +45,6 @@ ci_scripts:
- export TEST_PRE_COMMANDS=True
post_commands:
- export TEST_POST_COMMANDS=True
- template: remote
pre_commands:
- cat bones-scripts/remote.sh
host: gl
- template: test
pre_commands:
- cat bones-scripts/test-for-remote.sh
output_name: test-for-remote
coverage: true
- template: remote-script
pre_commands:
- cat bones-scripts/remote-test.sh
remote_script: test-for-remote
output_name: remote-test
host: gl
coverage: true
- template: docs
pre_commands:
- cat bones-scripts/docs.sh
Expand Down
12 changes: 0 additions & 12 deletions .templates/remote.sh.template

This file was deleted.

7 changes: 1 addition & 6 deletions actions/coverage-report/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,7 @@ runs:
with:
name: coverage-report
path: htmlcov
- uses: ewjoachim/python-coverage-comment-action@v3
- uses: py-cov-action/python-coverage-comment-action@v3
if: ${{ always() }}
with:
GITHUB_TOKEN: ${{ github.token }}
COMMENT_TEMPLATE: |
{% extends "base" %}
{% block coverage_single_file_title %}
### {{ filename }}
{% endblock %}
3 changes: 2 additions & 1 deletion nengo_bones/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,8 @@ def license_text(license, project_name):
See the License for the specific language governing permissions and
limitations under the License.
"""
elif license == "gpl-v2":
else:
assert license == "gpl-v2"
text = """\
**GPL v2 License**

Expand Down
56 changes: 0 additions & 56 deletions nengo_bones/templates/remote-script.sh.template

This file was deleted.

114 changes: 0 additions & 114 deletions nengo_bones/templates/remote.sh.template

This file was deleted.

1 change: 1 addition & 0 deletions nengo_bones/templates/setup.cfg.template
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ disable =
too-many-instance-attributes,
too-many-lines,
too-many-locals,
too-many-positional-arguments,
too-many-return-statements,
too-many-statements,
unexpected-keyword-arg,
Expand Down
22 changes: 0 additions & 22 deletions nengo_bones/tests/test_generate_bones.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,17 +58,6 @@ def test_ci_scripts(tmp_path):
- post command 1
- template: docs
- template: deploy
- template: remote-script
remote_script: test
output_name: remote-test
azure_name: azure-name
azure_group: azure-group
coverage: true
- template: remote-script
remote_script: docs
output_name: remote-docs
remote_vars:
remote_var: remote_val
""",
)

Expand Down Expand Up @@ -127,17 +116,6 @@ def has_line(filename, target, startswith=True):

assert has_line(".ci/deploy.sh", "exe bones check-deploy")

assert has_line(
".ci/remote-test.sh",
"exe az vm start --resource-group azure-group --name azure-name",
)
assert has_line(".ci/remote-test.sh", "bash .ci/test.sh install")
assert has_line(".ci/remote-test.sh", 'COVERAGE_FILE="tmp/dummy')

assert has_line(".ci/remote-docs.sh", 'export remote_var="remote_val"')
assert has_line(".ci/remote-docs.sh", "bash .ci/docs.sh install")
assert has_line(".ci/remote-docs.sh", 'REMOTE_FAILED_FILE="tmp/dummy')


def test_ci_script_custom_template(tmp_path):
(tmp_path / ".templates").mkdir()
Expand Down
2 changes: 1 addition & 1 deletion nengo_bones/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
tagged with the version.
"""

version_info = (24, 1, 22) # bones: ignore
version_info = (24, 9, 20) # bones: ignore

name = "nengo-bones"
dev = 0
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ disable =
too-many-instance-attributes,
too-many-lines,
too-many-locals,
too-many-positional-arguments,
too-many-return-statements,
too-many-statements,
unexpected-keyword-arg,
Expand Down
Loading