Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core Add] Add support to Ed25519 #3507

Merged
merged 2 commits into from
Jan 9, 2025
Merged

[Core Add] Add support to Ed25519 #3507

merged 2 commits into from
Jan 9, 2025

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Oct 2, 2024

Description

This pr adds support to Ed25519 as is suggested in #3506

Tested with test vectors from RFC 8032 (https://datatracker.ietf.org/doc/html/rfc8032)

Fixes # #3506

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • TestGenerateKeyPair
  • TestGetPublicKey
  • TestSignAndVerify
  • TestInvalidPrivateKeySize
  • TestInvalidSignatureSize
  • TestInvalidPublicKeySize
  • TestVectorCase1
  • TestVectorCase2
  • TestVectorCase3

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y Jim8y changed the base branch from master to HF_Echidna October 2, 2024 12:51
@Jim8y Jim8y marked this pull request as draft October 2, 2024 12:59
@Jim8y Jim8y marked this pull request as ready for review October 2, 2024 13:01
@Jim8y Jim8y requested review from vncoelho and a team October 2, 2024 13:01
@Jim8y
Copy link
Contributor Author

Jim8y commented Oct 2, 2024

@EdgeDLT

shargon
shargon reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ut for false verification?

src/Neo/SmartContract/Native/CryptoLib.cs Outdated Show resolved Hide resolved
@Jim8y
Copy link
Contributor Author

Jim8y commented Oct 3, 2024

Add ut for false verification?

sure

AnnaShaleva
AnnaShaleva reviewed Oct 7, 2024
View reviewed changes
src/Neo/SmartContract/Native/CryptoLib.cs
verifier.BlockUpdate(message, 0, message.Length);
return verifier.VerifySignature(signature);
}
catch (Exception)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I was talking only about ArgumentException, e.g. only about input data of invalid length and some other ArgumentException thrown by this part of code. However, catching any exception is a valid solution as far.

@roman-khimov, what do you think about cases when we should return true/false or FAULT VM?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be both ways, but we need to know all of the exceptions that can happen in this block. Some are likely OK to be converted to false result (invalid signature), some may not (verifier constructor failure?). I'd expect some symmetry to ECDSA verification function. Like what happens if the key is wrong?

shargon
shargon reviewed Jan 2, 2025
View reviewed changes
src/Neo/VM/Helper.cs Outdated Show resolved Hide resolved
src/Neo/VM/Helper.cs Outdated Show resolved Hide resolved
@nan01ab
Copy link
Contributor

nan01ab commented Jan 3, 2025

LGTM

@Jim8y
Copy link
Contributor Author

Jim8y commented Jan 7, 2025

LGTM

need approval

@Jim8y
Copy link
Contributor Author

Jim8y commented Jan 8, 2025

@roman-khimov @AnnaShaleva i think neogo need to impl this as well, please take a look.

@NGDAdmin NGDAdmin merged commit b1a3ea3 into neo-project:HF_Echidna Jan 9, 2025
7 checks passed
@AnnaShaleva AnnaShaleva mentioned this pull request Jan 20, 2025
Open
NGDAdmin pushed a commit that referenced this pull request Jan 23, 2025
@Jim8y @shargon
@cschuchardt88 @nan01ab @roman-khimov @AnnaShaleva @vncoelho
Add hardfork HF_Echidna (#3454)
befe7f6 
* add hardofork HF_Echidna

* Add entries to `Designation` event (#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* add hardofork HF_Echidna

* Add entries to `Designation` event (#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* add hardofork HF_Echidna

* Add entries to `Designation` event (#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* format

* Fixed typo

* Added back #3397

* Fixed tests

* fixed global.json

* Update src/Neo/Neo.csproj

* Update src/Neo/Neo.csproj

* [`Fix`]: integer overflow in `JumpTable.SubStr ` (#3496)

* fix: int overflow in SubStr

* fix: int overflow in SubStr

* format

* Versioning change

* Clean

* Rename

* Show change

* Space

* remove duplicated lines in gitignroe

---------

Co-authored-by: Jimmy <[email protected]>
Co-authored-by: Shargon <[email protected]>

* Fix NEO callstates (#3599)

* Allow callstates to use HF

* Rename to method

* Other rename

* Change the way

* Reduce changes

* Reduce changes

* Adapt name always

* Avoid string when only is lower the first char

* UT

* Test all

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

* Reuse Load from stream

* Unify

* Fix default logic

* Change ContractMethod to allowMultiple

* Use LowerInvariant

* Move CheckingHardfork

* Remove optional arg

* Fix build

* Avoid file not found error

---------

Co-authored-by: Christopher Schuchardt <[email protected]>

* fix tests error (#3636)

* fux build error

* Update src/Neo/SmartContract/ApplicationEngine.cs

---------

Co-authored-by: Shargon <[email protected]>

* NeoToken: accept candidate registration via onNEP17Payment (#3597)

Solves two problems:
 * inability to estimate GAS needed for registerCandidate in a regular way
   because of its very high fee (more than what normal RPC servers allow)
 * inability to have MaxBlockSystemFee lower than the registration price
   which is very high on its own (more than practically possible to execute)

Fixes #3552.

Signed-off-by: Roman Khimov <[email protected]>

* specify the argument exception information.

* Fix Ut (#3635)

* NeoToken: add NEP-27 to supported standards list starting from Echidna (#3643)

#3597 introduces `onNEP17Payment`
handler to native NeoToke contract starting from Echidna hardfork. We
need to update the list of supported standards respectively.

Signed-off-by: Anna Shaleva <[email protected]>

* ut: fix HF_Echidna unit tests (#3646)

* Fix UT

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: nan01ab <[email protected]>

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: nan01ab <[email protected]>

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

---------

Co-authored-by: Jimmy <[email protected]>
Co-authored-by: nan01ab <[email protected]>
Co-authored-by: Christopher Schuchardt <[email protected]>

* [Core Add] Add support to Ed25519 (#3507)

* fix unnecessary change

* Clean using

---------

Co-authored-by: Fernando Diaz Toledano <[email protected]>

* Fix `HF_Echidna` comments (#3679)

* Fix obsolete

* Fix https://github.com/neo-project/neo/pull/3454/files#r1912152270

* Fix comment

* Update RoleManagement.cs

* Unset HF_Echidna

* Revert getTransaction

* Revert verifyWithECDsa

* format

---------

Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
Co-authored-by: Shargon <[email protected]>
Co-authored-by: Christopher Schuchardt <[email protected]>
Co-authored-by: nan01ab <[email protected]>
Co-authored-by: Roman Khimov <[email protected]>
Co-authored-by: Anna Shaleva <[email protected]>
Co-authored-by: Vitor Nazário Coelho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov left review comments

@shargon shargon shargon approved these changes

@nan01ab nan01ab nan01ab approved these changes

@vncoelho vncoelho Awaiting requested review from vncoelho

@AnnaShaleva AnnaShaleva Awaiting requested review from AnnaShaleva

@cschuchardt88 cschuchardt88 Awaiting requested review from cschuchardt88

Assignees
No one assigned
Labels
Ready to Merge Waiting for Review Waiting-Hardfork
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Jim8y @nan01ab @shargon @vncoelho @roman-khimov @AnnaShaleva @NGDAdmin