-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialized storage cache #3669
base: master
Are you sure you want to change the base?
Serialized storage cache #3669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, it should work this way. But I'd suggest to process existing chains with this change in order to ensure that cache persisting logic works as expected.
benchmarks/Neo.Benchmarks/Program.cs
Outdated
BenchmarkRunner.Run<Bechmarks_ReadOnlyStoreView>(); | ||
BenchmarkRunner.Run<Bechmarks_LevelDB>(); | ||
BenchmarkRunner.Run<Benchmarks_Cache>(); | ||
//BenchmarkRunner.Run<Benchmarks_UInt160>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why comment out these lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we run only one benchmark, isn't it?
Co-authored-by: nan01ab <[email protected]>
Co-authored-by: nan01ab <[email protected]>
@shargon conflict please |
@cschuchardt88 Failed to unzip file "obj/libleveldb-win-arm64.zip" because the file does not exist or is inaccessible. [TargetFramework=net9.0] |
LGTM |
@shargon |
Description
Close #3145
Alternative to #3146
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: