Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialized storage cache #3669

Open
wants to merge 55 commits into
base: master
Choose a base branch
from
Open

Serialized storage cache #3669

wants to merge 55 commits into from

Conversation

shargon
Copy link
Member

@shargon shargon commented Jan 13, 2025

Description

Close #3145
Alternative to #3146

| Method       | Mean      | Error     | StdDev    |
|------------- |----------:|----------:|----------:|
| WithCache    |  40.66 us |  0.130 us |  0.115 us |
| WithoutCache | 810.69 us | 15.792 us | 13.999 us |

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Pending

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon mentioned this pull request Jan 13, 2025
15 tasks
@shargon shargon added the Blocked This issue can't be worked at the moment label Jan 13, 2025
@shargon shargon removed the Blocked This issue can't be worked at the moment label Jan 20, 2025
@shargon shargon marked this pull request as ready for review January 21, 2025 10:51
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, it should work this way. But I'd suggest to process existing chains with this change in order to ensure that cache persisting logic works as expected.

@Jim8y Jim8y self-assigned this Jan 23, 2025
Jim8y
Jim8y previously approved these changes Feb 11, 2025
BenchmarkRunner.Run<Bechmarks_ReadOnlyStoreView>();
BenchmarkRunner.Run<Bechmarks_LevelDB>();
BenchmarkRunner.Run<Benchmarks_Cache>();
//BenchmarkRunner.Run<Benchmarks_UInt160>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment out these lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we run only one benchmark, isn't it?

@Jim8y
Copy link
Contributor

Jim8y commented Feb 13, 2025

@shargon conflict please

@shargon shargon mentioned this pull request Feb 13, 2025
15 tasks
@shargon shargon added the Blocked This issue can't be worked at the moment label Feb 13, 2025
@shargon
Copy link
Member Author

shargon commented Feb 15, 2025

@cschuchardt88 Failed to unzip file "obj/libleveldb-win-arm64.zip" because the file does not exist or is inaccessible. [TargetFramework=net9.0]
0 Warning(s)

@nan01ab
Copy link
Contributor

nan01ab commented Feb 23, 2025

LGTM

@cschuchardt88
Copy link
Member

cschuchardt88 commented Feb 23, 2025

@cschuchardt88 Failed to unzip file "obj/libleveldb-win-arm64.zip" because the file does not exist or is inaccessible. [TargetFramework=net9.0] 0 Warning(s)

@shargon
Sounds like a dotnet issue or problem with github vm. I'm still testing solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked This issue can't be worked at the moment Waiting for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize OnPersist
5 participants