Enable more clang-tidy checks

.clang-tidy

@@ -4,7 +4,6 @@ Checks: >
 
   bugprone-*,
   -bugprone-macro-parentheses,
-  -bugprone-misplaced-widening-cast,
   -bugprone-exception-escape,
   -bugprone-signed-char-misuse,
 
@@ -18,6 +17,7 @@ Checks: >
   concurrency-*,
 
   cppcoreguidelines-*,
+  -cppcoreguidelines-avoid-const-or-ref-data-members,
   -cppcoreguidelines-avoid-non-const-global-variables,
   -cppcoreguidelines-macro-usage,
   -cppcoreguidelines-pro-bounds-constant-array-index,
@@ -30,22 +30,18 @@ Checks: >
 
   misc-*,
   -misc-use-anonymous-namespace,
-  -misc-const-correctness,
 
   modernize-*,
 
   performance-*,
 
   readability-*,
-  -readability-const-return-type,
   -readability-function-cognitive-complexity,
   -readability-identifier-length,
   -readability-identifier-naming,
 
   -*-avoid-c-arrays,
   -*-magic-numbers,
-  -*-non-private-member-variables-in-classes,
-  -*-special-member-functions,
 
 WarningsAsErrors: "*"
 FormatStyle: none

src/lib/CMakeLists.txt

@@ -47,7 +47,6 @@ target_sources(neo_fft_tests
         "neo/fft/stft_test.cpp"
         "neo/fft/twiddle_test.cpp"
 
-
         "neo/fixed_point/fixed_point_test.cpp"
 
         "neo/math/a_weighting_test.cpp"

src/lib/neo/fft/kernel/radix2.hpp

@@ -45,10 +45,10 @@ struct c2c_dit2_v1
 
             for (auto k = 0; std::cmp_less(k, size); k += stride) {
                 for (auto pair = 0; pair < stage_length; ++pair) {
-                    auto const tw = twiddles[static_cast<std::size_t>(pair * tw_stride)];
+                    auto const tw = twiddles[pair * tw_stride];
 
-                    auto const i1 = static_cast<std::size_t>(k + pair);
-                    auto const i2 = static_cast<std::size_t>(k + pair + stage_length);
+                    auto const i1 = k + pair;
+                    auto const i2 = i1 + stage_length;
 
                     auto const temp = x[i1] + tw * x[i2];
                     x[i2]           = x[i1] - tw * x[i2];