Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain return values from vector functions #1104

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

JPryce-Aklundh
Copy link
Collaborator

No description provided.

@JPryce-Aklundh JPryce-Aklundh added cherry-pick-this-to-5.x Cherry pick this PR changes to the 5.x branch cherry-pick-this-to-cypher-25 labels Nov 11, 2024
Copy link
Contributor

@parnmatt parnmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, just suggesting being consistent with the numbers being in backticks

@@ -35,6 +35,8 @@ For more details, see the {link-vector-indexes}#similarity-functions[vector inde
| Both vectors must be of the same dimension.
| Both vectors must be {link-vector-indexes}#indexes-vector-similarity-cosine[*valid*] with respect to cosine similarity.
| The implementation is identical to that of the latest available vector index provider (`vector-2.0`).
| `vector.similarity.cosine()` returns the neighborhood of nodes along with their respective cosine similarity scores, sorted in descending order of similarity.
The similarity score range from `0` and 1, with scores closer to `1` indicating a higher degree of similarity between the indexed vector and the query vector.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The similarity score range from `0` and 1, with scores closer to `1` indicating a higher degree of similarity between the indexed vector and the query vector.
The similarity score range from `0` and `1`, with scores closer to `1` indicating a higher degree of similarity between the indexed vector and the query vector.

@@ -63,6 +65,8 @@ For more details, see the {link-vector-indexes}#similarity-functions[vector inde
| Both vectors must be of the same dimension.
| Both vectors must be {link-vector-indexes}#indexes-vector-similarity-euclidean[*valid*] with respect to Euclidean similarity.
| The implementation is identical to that of the latest available vector index provider (`vector-2.0`).
| `vector.similarity.euclidean()` returns the neighborhood of nodes along with their respective Euclidean similarity scores, sorted in descending order of similarity.
The similarity score range from `0` and 1, with scores closer to `1` indicating a higher degree of similarity between the indexed vector and the query vector.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The similarity score range from `0` and 1, with scores closer to `1` indicating a higher degree of similarity between the indexed vector and the query vector.
The similarity score range from `0` and `1`, with scores closer to `1` indicating a higher degree of similarity between the indexed vector and the query vector.

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@JPryce-Aklundh JPryce-Aklundh merged commit df29ec0 into neo4j:dev Nov 11, 2024
5 checks passed
@JPryce-Aklundh JPryce-Aklundh deleted the update_vector_functions branch November 11, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-this-to-5.x Cherry pick this PR changes to the 5.x branch cherry-pick-this-to-cypher-25
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants