Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SHOW SETTINGS table to include dbms.cluster.network.connect_timeout #862

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

JPryce-Aklundh
Copy link
Collaborator

@JPryce-Aklundh JPryce-Aklundh commented Jan 23, 2024

Failure resolved when https://github.com/neo-technology/neo4j/pull/23939 is merged

@JPryce-Aklundh JPryce-Aklundh changed the title Update SHOW SETTINGS table Update SHOW SETTINGS table to include dbms.cluster.network.connect_timeout Jan 23, 2024
@@ -227,6 +227,10 @@ LIMIT 10
| "20s"
| "Time out for protocol negotiation handshake."

| "dbms.cluster.network.connect_timeout"
| "30s"
| "The maximum amount of time we wait to establish a network connection."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the description of this setting. See https://trello.com/c/aWrYCE5Y/213-document-dbmsclusternetworkconnecttimeout

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also, I think it wil be introduced in 5.17.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is a 5.17 feature. But this table only shows what is returned by the show settings command (so no release info etc.)

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@JPryce-Aklundh JPryce-Aklundh merged commit 3fcf9f5 into neo4j:dev Jan 26, 2024
5 checks passed
@JPryce-Aklundh JPryce-Aklundh deleted the fix_show_settings2 branch January 26, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants