Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad GenAI batching example #891

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Fix bad GenAI batching example #891

merged 4 commits into from
Feb 23, 2024

Conversation

nilsceberg
Copy link
Contributor

The current example doesn't do what it says it does

@renetapopova renetapopova self-requested a review February 21, 2024 10:48
renetapopova
renetapopova requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nilsceberg. I added some comments.

modules/ROOT/pages/genai-integrations.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/genai-integrations.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/genai-integrations.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/genai-integrations.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/genai-integrations.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/genai-integrations.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/genai-integrations.adoc Outdated Show resolved Hide resolved
@renetapopova renetapopova force-pushed the dev-fix-bad-genai-example branch from 06b6dfb to eb1f941 Compare February 23, 2024 15:55
@renetapopova renetapopova self-requested a review February 23, 2024 15:56
renetapopova
renetapopova approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good now.

@renetapopova renetapopova added cherry-pick-this-to-5.x Cherry pick this PR changes to the 5.x branch and removed dev labels Feb 23, 2024
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova merged commit 3de9b75 into neo4j:dev Feb 23, 2024
5 checks passed
renetapopova pushed a commit to renetapopova/docs-cypher that referenced this pull request Feb 23, 2024
@nilsceberg @renetapopova
Fix bad GenAI batching example (neo4j#891)
1752fdc 
The current example doesn't do what it says it does
@renetapopova renetapopova mentioned this pull request Feb 23, 2024
Merged
renetapopova added a commit that referenced this pull request Feb 23, 2024
@renetapopova @nilsceberg
Fix bad GenAI batching example (#891) (#894)
de07849 
Cherry-picked from #891

Co-authored-by: Nils Ceberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikwattro ikwattro ikwattro left review comments

@renetapopova renetapopova renetapopova approved these changes

Assignees
No one assigned
Labels
5.16 5.17 cherry-pick-this-to-5.x Cherry pick this PR changes to the 5.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nilsceberg @neo-technology-commit-status-publisher @ikwattro @renetapopova