-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify directives presentation #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few suggestions and questions.
=== Definition | ||
|
||
// tba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=== Definition | |
// tba |
It's too complicated to put as a definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a specific version for validate
:
[source, graphql, indent=0]
----
"""
This is a simpler version of the authentication directive to be used in the validate-document step.
"""
directive @authentication(
"""operations"""
operations: [String]
jwt: String
) on OBJECT | FIELD_DEFINITION | SCHEMA
----
=== Definition | ||
|
||
// tba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=== Definition | |
// tba |
As with authorization
this is too complicated to write a simple definition for, I think.
There exists a "simple" case for validate
:
[source, graphql, indent=0]
----
"""
This is a simpler version of the authorization directive to be used in the validate-document step.
"""
directive @authorization(
"""filter"""
filter: [String]
"""validate"""
validate: [String]
) on OBJECT | FIELD_DEFINITION
----
=== Definition | ||
|
||
// tba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=== Definition | |
// tba |
Same as others.
[source, graphql, indent=0]
----
"""
This is a simpler version of the subscriptionsAuthorization directive to be used in the validate-document step.
"""
directive @subscriptionsAuthorization(
"""filter"""
filter: [String]!
) on OBJECT | FIELD_DEFINITION
----
modules/ROOT/pages/directives/schema-configuration/type-configuration.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Webb <[email protected]> Co-authored-by: Lidia Zuin <[email protected]>
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
added a number of "tba" in comments. mostly missing definitions, but on some occasions i wasn't sure which parts of the follow-up sections could got to the "usage" subsection.