Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification param format #192

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

renetapopova
Copy link
Collaborator

I think we are not using backticks in a consistent way in the code. So, maybe we should reconsider their usage and leave them just for the docs.

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@Lojjs
Copy link
Contributor

Lojjs commented Oct 17, 2024

I think we are not using backticks in a consistent way in the code. So, maybe we should reconsider their usage and leave them just for the docs.

I have not looked properly at the details yet. I know this is rather messy for notifications, hopefully a bit better for the new errors. We can change the status description in the code but not the old description because those are breaking. The formatting of docs we can change however we like of course

@renetapopova
Copy link
Collaborator Author

I think we are not using backticks in a consistent way in the code. So, maybe we should reconsider their usage and leave them just for the docs.

I have not looked properly at the details yet. I know this is rather messy for notifications, hopefully a bit better for the new errors. We can change the status description in the code but not the old description because those are breaking. The formatting of docs we can change however we like of course

Let's keep the consistency only for the docs.

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our discussion I think this looks fine

@renetapopova renetapopova merged commit 11ae1de into neo4j:dev Oct 22, 2024
5 checks passed
@renetapopova renetapopova deleted the notification-param-format branch October 22, 2024 12:05
renetapopova added a commit to renetapopova/docs-status-codes that referenced this pull request Oct 22, 2024
I think we are not using backticks in a consistent way in the code. So,
maybe we should reconsider their usage and leave them just for the docs.
renetapopova added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants