-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification param format #192
Notification param format #192
Conversation
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
I have not looked properly at the details yet. I know this is rather messy for notifications, hopefully a bit better for the new errors. We can change the status description in the code but not the old description because those are breaking. The formatting of docs we can change however we like of course |
Let's keep the consistency only for the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our discussion I think this looks fine
I think we are not using backticks in a consistent way in the code. So, maybe we should reconsider their usage and leave them just for the docs.
I think we are not using backticks in a consistent way in the code. So, maybe we should reconsider their usage and leave them just for the docs.