-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codes starting with 42 #196
Add codes starting with 42 #196
Conversation
6ac8f4d
to
d6af349
Compare
Co-authored-by: Louise Berglund <[email protected]>
Co-authored-by: Louise Berglund <[email protected]>
Co-authored-by: Louise Berglund <[email protected]>
Co-authored-by: Louise Berglund <[email protected]>
Co-authored-by: Louise Berglund <[email protected]>
Co-authored-by: Louise Berglund <[email protected]>
Co-authored-by: Louise Berglund <[email protected]>
Co-authored-by: Louise Berglund <[email protected]>
65ecf5f
to
dff364f
Compare
|
||
=== 42I47 | ||
|
||
Status description:: error: syntax error or access rule violation - parser error. Parser Error: `{ $msg }`. | ||
|
||
=== 42I50 | ||
|
||
Status description:: error: syntax error or access rule violation - token name too long. Invalid input `{ $input }`... A `{ $tokenType }` name cannot be longer than `{ $maxTokenLength }`. | ||
Status description:: error: syntax error or access rule violation - token name too long. Invalid input `{ $input }..`. A `{ $tokenType }` name cannot be longer than `{ $maxTokenLength }`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about putting the backticks in between the dots on this one. I guess the dots are supposed to be ... like in etc. but also they are in the end of a sentence. I leave it up to you, how you think it is best to format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was also not sure about this one. As I understood Emelie, the dots here mean that the displayed input is truncated. But the last dot should be a full stop, in my opinion; otherwise, the sentence will look unfinished. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was thinking the same way, let's keep it like this and change it later if someone would complain (which I doubt)
|
||
=== 42I02 | ||
|
||
Status description:: error: syntax error or access rule violation - invalid comment. Failed to parse comment. A comment starting with `'/*'` must also have a closing `'*/'`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked in the preview now and on this one the stars are creating som bold formatting instead of being visible so I think you need to escape them somehow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I've fixed the bold formatting and removed the backticks around the parameters, as they have quotes around them.
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Some of them are not marked as implemented in the spreadsheet, but I can see them in the code, --------- Co-authored-by: Louise Berglund <[email protected]>
Some of them are not marked as implemented in the spreadsheet, but I can see them in the code,