Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codes starting with 42 #196

Merged
merged 18 commits into from
Oct 25, 2024

Conversation

renetapopova
Copy link
Collaborator

Some of them are not marked as implemented in the spreadsheet, but I can see them in the code,

@renetapopova renetapopova requested a review from Lojjs October 22, 2024 16:21
@renetapopova renetapopova changed the title add 42 codes Add codes starting with 42 Oct 22, 2024
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Show resolved Hide resolved
@Lojjs Lojjs self-assigned this Oct 23, 2024

=== 42I47

Status description:: error: syntax error or access rule violation - parser error. Parser Error: `{ $msg }`.

=== 42I50

Status description:: error: syntax error or access rule violation - token name too long. Invalid input `{ $input }`... A `{ $tokenType }` name cannot be longer than `{ $maxTokenLength }`.
Status description:: error: syntax error or access rule violation - token name too long. Invalid input `{ $input }..`. A `{ $tokenType }` name cannot be longer than `{ $maxTokenLength }`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about putting the backticks in between the dots on this one. I guess the dots are supposed to be ... like in etc. but also they are in the end of a sentence. I leave it up to you, how you think it is best to format

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also not sure about this one. As I understood Emelie, the dots here mean that the displayed input is truncated. But the last dot should be a full stop, in my opinion; otherwise, the sentence will look unfinished. 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was thinking the same way, let's keep it like this and change it later if someone would complain (which I doubt)


=== 42I02

Status description:: error: syntax error or access rule violation - invalid comment. Failed to parse comment. A comment starting with `'/*'` must also have a closing `'*/'`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked in the preview now and on this one the stars are creating som bold formatting instead of being visible so I think you need to escape them somehow

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I've fixed the bold formatting and removed the backticks around the parameters, as they have quotes around them.

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova requested a review from Lojjs October 25, 2024 11:59
@renetapopova renetapopova merged commit 372d2ba into neo4j:gqlstatus-errors Oct 25, 2024
5 checks passed
@renetapopova renetapopova deleted the gql-batch-3 branch October 25, 2024 12:20
renetapopova added a commit that referenced this pull request Oct 31, 2024
Some of them are not marked as implemented in the spreadsheet, but I can
see them in the code,

---------

Co-authored-by: Louise Berglund <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants