Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the rest of Neo4j defined GQLSTATUS codes for data exceptions #200

Merged

Conversation

NataliaIvakina
Copy link
Collaborator

No description provided.

@NataliaIvakina NataliaIvakina requested a review from Lojjs October 24, 2024 13:39
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Some mixed feedback on smaller things and some questions for Isak and Wilco for discrepancies I found but where unsure about

modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
Comment on lines +383 to +385
// === 22N72

// Status description:: error: data exception - index required by existing constraint. A requested operation can not be performed on the specified index because the index is part of a constraint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not in the codebase either, but in this case I do not know why. Any clue @WilcoNeo or @anderson4j ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My best guess is it's in a PR not yet merged or it's usage has been removed since it's not in error codes sheet either. I would check with @brunobuss who added it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find it in any of my open PRs

modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Show resolved Hide resolved
Comment on lines +535 to +537
// === 22NFF

// Status description:: error: data exception - referent does not exist. The referent of the specified reference does not exist.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this one was added by Stefan in the spreadsheet, but it is not in the codebase and not used in any of the teams' errors in the other spreadsheet. Also it has a much higher number than the other 22x errors so I get the feeling there is a reason it is there but I don't know it. Maybe we can keep it in the spreadsheet for now, but exclude it from docs until we know if it has any usages?

@NataliaIvakina
Copy link
Collaborator Author

@Lojjs, I suppose we should wait till https://github.com/neo-technology/neo4j/pull/27810 is merged. Right?

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only remaining comments are about two codes which are potentially removed, but as those are commented out anyway we can merge it like this and clean it up later if it turns out they are never used in the end.

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@NataliaIvakina NataliaIvakina merged commit 1d5ecd0 into neo4j:gqlstatus-errors Oct 28, 2024
5 checks passed
@NataliaIvakina NataliaIvakina deleted the gqlstatus-data-exceptions branch October 28, 2024 14:20
renetapopova pushed a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants