-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the rest of Neo4j defined GQLSTATUS codes for data exceptions #200
Add the rest of Neo4j defined GQLSTATUS codes for data exceptions #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Some mixed feedback on smaller things and some questions for Isak and Wilco for discrepancies I found but where unsure about
// === 22N72 | ||
|
||
// Status description:: error: data exception - index required by existing constraint. A requested operation can not be performed on the specified index because the index is part of a constraint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not in the codebase either, but in this case I do not know why. Any clue @WilcoNeo or @anderson4j ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My best guess is it's in a PR not yet merged or it's usage has been removed since it's not in error codes sheet either. I would check with @brunobuss who added it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find it in any of my open PRs
// === 22NFF | ||
|
||
// Status description:: error: data exception - referent does not exist. The referent of the specified reference does not exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this one was added by Stefan in the spreadsheet, but it is not in the codebase and not used in any of the teams' errors in the other spreadsheet. Also it has a much higher number than the other 22x errors so I get the feeling there is a reason it is there but I don't know it. Maybe we can keep it in the spreadsheet for now, but exclude it from docs until we know if it has any usages?
Co-authored-by: Louise Berglund <[email protected]>
Co-authored-by: Louise Berglund <[email protected]>
@Lojjs, I suppose we should wait till https://github.com/neo-technology/neo4j/pull/27810 is merged. Right? |
Co-authored-by: Louise Berglund <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only remaining comments are about two codes which are potentially removed, but as those are commented out anyway we can merge it like this and clean it up later if it turns out they are never used in the end.
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Co-authored-by: Louise Berglund <[email protected]>
No description provided.