Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add standard defined GQLSTATUS codes for data exceptions #201

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Add standard defined GQLSTATUS codes for data exceptions #201

merged 3 commits into from
Oct 30, 2024

Conversation

NataliaIvakina
Copy link
Collaborator

No description provided.

@NataliaIvakina NataliaIvakina requested a review from Lojjs October 29, 2024 11:35
Lojjs
Lojjs reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we must have messed up the spreadsheet somehow for these ones, because it is actually only 22000, 22003 and 22N88 of them which are used.

modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
@Lojjs Lojjs self-assigned this Oct 29, 2024
@NataliaIvakina
Copy link
Collaborator Author

I think we must have messed up the spreadsheet somehow for these ones, because it is actually only 22000, 22003 and 22N88 of them which are used.

Ok, then I'll remove them from the PR and comment on the spreadsheet.

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

Lojjs
Lojjs approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, looks good now

@NataliaIvakina NataliaIvakina merged commit 6e706d8 into neo4j:gqlstatus-errors Oct 30, 2024
5 checks passed
@NataliaIvakina NataliaIvakina deleted the standard-defined-codes branch October 30, 2024 13:19
renetapopova pushed a commit that referenced this pull request Oct 31, 2024
@NataliaIvakina @Lojjs @renetapopova
Add standard defined GQLSTATUS codes for data exceptions (#201)
01b7e93 
Co-authored-by: Louise Berglund <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lojjs Lojjs Lojjs approved these changes

Assignees

@Lojjs Lojjs

Labels
5.26 gqlstatus-errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NataliaIvakina @neo-technology-commit-status-publisher @Lojjs