Improve sortAndPaginationFactory

neo4j · Mar 5, 2024 · aa6c346 · aa6c346
1 parent 295bd4a
commit aa6c346
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 17 deletions.
diff --git a/packages/graphql/src/schema/make-augmented-schema.ts b/packages/graphql/src/schema/make-augmented-schema.ts
@@ -555,7 +555,6 @@ function generateObjectType({
             graphqlDirectivesToCompose(propagatedDirectives)
         );
 
-        // FOR CONCRETE
         composer.Query.addFields({
             [concreteEntityAdapter.operations.rootTypeFieldNames.connection]: rootConnectionResolver({
                 composer,
@@ -695,7 +694,6 @@ function generateInterfaceObjectType({
             graphqlDirectivesToCompose(propagatedDirectives)
         );
 
-        // FOR CONCRETE
         composer.Query.addFields({
             [interfaceEntityAdapter.operations.rootTypeFieldNames.connection]: rootConnectionResolver({
                 composer,

diff --git a/packages/graphql/src/translate/queryAST/factory/Operations/ConnectionFactory.ts b/packages/graphql/src/translate/queryAST/factory/Operations/ConnectionFactory.ts
@@ -112,15 +112,12 @@ export class ConnectionFactory {
 
         // These sort fields will be duplicated on nested "CompositeConnectionPartial"
 
-        // TODO: this if shouldn't be needed
-        // if (relationship) {
         this.hydrateConnectionOperationsASTWithSort({
             entityOrRel: relationship ?? target,
             resolveTree,
             operation: compositeConnectionOp,
             context,
         });
-        // }
         return compositeConnectionOp;
     }
 

diff --git a/packages/graphql/src/translate/queryAST/factory/SortAndPaginationFactory.ts b/packages/graphql/src/translate/queryAST/factory/SortAndPaginationFactory.ts
@@ -55,17 +55,6 @@ export class SortAndPaginationFactory {
         entityOrRel: EntityAdapter | RelationshipAdapter,
         context: Neo4jGraphQLTranslationContext
     ): { edge: Sort[]; node: Sort[] } {
-        if (isConcreteEntity(entityOrRel)) {
-            const nodeSortFields = this.createPropertySort({
-                optionArg: options.node ?? {},
-                entity: entityOrRel,
-                context,
-            });
-            return {
-                edge: [],
-                node: nodeSortFields,
-            };
-        }
         if (isRelationshipEntity(entityOrRel)) {
             const nodeSortFields = this.createPropertySort({
                 optionArg: options.node ?? {},
@@ -82,7 +71,6 @@ export class SortAndPaginationFactory {
                 node: nodeSortFields,
             };
         }
-        // Is union or interface
 
         const nodeSortFields = this.createPropertySort({
             optionArg: options.node ?? {},