Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code-cov while preserving test coverage archival #4710

Merged
merged 15 commits into from
Feb 21, 2024

Conversation

mjfwebb
Copy link
Contributor

@mjfwebb mjfwebb commented Feb 15, 2024

Description

This PR removes code-cov test coverage uploads but preserves the archival of the test coverage artifacts.

Complexity

Low

Copy link

changeset-bot bot commented Feb 15, 2024

⚠️ No Changeset found

Latest commit: 4695f92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@darrellwarde
Copy link
Contributor

Do we need the disable-coverage-archival or can we just always archive? Does it really matter?

Looks like something is a bit broken on the job which merged the artifacts.

@mjfwebb mjfwebb enabled auto-merge (squash) February 21, 2024 15:30
@mjfwebb mjfwebb merged commit a6e9047 into neo4j:dev Feb 21, 2024
81 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
@mjfwebb mjfwebb deleted the remove-codecov branch February 21, 2024 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Pull requests
Development

Successfully merging this pull request may close these issues.

3 participants