Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick: Fix relationship filter on interfaces #5890 #5906

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

mjfwebb
Copy link
Contributor

@mjfwebb mjfwebb commented Dec 20, 2024

This is a cherry pick of PR #5890 into version 6 (dev): Fix relationship filter on interfaces

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: ec441fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@neo4j/graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Dec 20, 2024

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 38 50 1134
aggregations.TopLevelAggregateWithMultipleFields 6802 6802 53 74 1134
aggregations.NestedAggregation 15407 15407 58 107 2174
aggregations.AggregationWithWhere 10833 10833 40 58 2174
aggregations.AggregationWhereWithinNestedRelationships 20097917 20097917 1946 2079 2008534
aggregations.AggregationWhereWithinNestedConnections 20097917 20097917 1901 1931 2008534
aggregations.NestedCountFromMovieToActors 8603 8603 33 43 2174
aggregations.NestedCountFromActorsToMovie 8791 8791 37 44 2174
aggregations.DeeplyNestedCount 10052335 10052335 2436 2066 2008534
aggregations.InterfacesAggregations 6242 6242 46 56 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 84 85 2080
batch-create.BatchCreate 4200 4200 130 148 600
batch-create.BatchCreateSmall 77 77 101 70 11
connect.createAndConnect 6433 6433 141 188 3003
connections.Connection 12951 12951 62 69 2174
connections.NestedConnection 37705 37705 154 143 4516
create.SimpleMutation 7 7 68 67 1
cypher-directive.TopLevelMutationDirective 1135 1135 25 31 1134
delete.SimpleDelete 19401 19401 703 718 1040
2925.SingleRelationshipFilter 5245 5245 44 53 1040
2925.SingleRelationshipRequiredFilter 5201 5201 36 47 1040
query.SimpleQuery 3121 3121 24 27 1040
query.SimpleQueryWithRelationship 15031 15031 39 47 2174
query.SimpleQueryWithNestedWhere 8713 8713 51 56 2154
query.Nested 10084891 10084891 6527 6411 2008534
query.NestedWithFilter 10064992 10064992 6608 6366 2004000
query.OrFilterOnRelationships 36946 36712 211 223 2027
query.QueryWithNestedIn 14468 14468 64 76 1956
query.NestedConnectionWhere 8703 8703 53 73 2174
query.DeeplyNestedConnectionWhere 8702 8702 103 100 2174
query.DeeplyNestedWithRelationshipFilters 17357 17357 139 195 1552
query.NestedWithRelationshipSingleFilters 3808 3808 142 210 1134
query.Fulltext 64 64 31 38 16
query.FulltextWithNestedQuery 516 516 42 52 84
sorting-and-cypher.TopLevelSortWithCypher 12961 12961 40 56 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 12961 12961 63 70 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 13096 13096 55 66 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 13096 13096 95 111 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 13720 13720 102 134 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 13266 13266 101 142 2174
sorting.SortMultipleTypes 3436 3436 84 94 1040
sorting.SortMultipleTypesWithCypherWithCypher 13321 13321 103 110 2174
sorting.SortOnNestedFields 12951 12951 41 55 2174
sorting.SortDeeplyNestedFields 39785 39785 78 92 4516
sorting.ConnectionWithSort 3271 3271 71 83 1040
unions.SimpleUnionQuery 321 321 61 69 35
unions.SimpleUnionQueryWithMissingFields 293 293 56 65 35
unions.NestedUnion 309975 309975 260 276 33033
unions.NestedUnionWithMissingFields 283949 283949 260 260 33033
update.NestedUpdate 14137 14137 94 99 2002

Old Schema Generation: 27.185s
Schema Generation: 27.028s
Old Subgraph Schema Generation: 28.153s
Subgraph Schema Generation: 27.496s

@mjfwebb mjfwebb merged commit 0e81510 into neo4j:dev Dec 20, 2024
41 checks passed
@mjfwebb mjfwebb deleted the fix-relationship-filter-on-interfaces branch December 20, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants