-
Notifications
You must be signed in to change notification settings - Fork 71
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Close socket if Bolt handshake fails
Co-authored-by: Rouven Bauer <[email protected]>
- Loading branch information
1 parent
62bae2d
commit 3f5f3f4
Showing
2 changed files
with
198 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| /* | ||
| * Copyright (c) "Neo4j" | ||
| * Neo4j Sweden AB [https://neo4j.com] | ||
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package connector_test | ||
|
|
||
| import ( | ||
| "github.com/neo4j/neo4j-go-driver/v4/neo4j/internal/connector" | ||
| . "github.com/neo4j/neo4j-go-driver/v4/neo4j/internal/testutil" | ||
| "io" | ||
| "net" | ||
| "testing" | ||
| "time" | ||
| ) | ||
|
|
||
| func TestConnect(outer *testing.T) { | ||
| outer.Parallel() | ||
|
|
||
| outer.Run("closes connection if Bolt handshake does not reach agreement", func(t *testing.T) { | ||
| clientConnection, server := setUp(t) | ||
| go func() { | ||
| server.acceptVersion(1, 0) | ||
| }() | ||
| connectionDelegate := &ConnDelegate{Delegate: clientConnection} | ||
| connector := &connector.Connector{SupplyConnection: supplyThis(connectionDelegate), SkipEncryption: true} | ||
|
|
||
| connection, err := connector.Connect("irrelevant", nil) | ||
|
|
||
| AssertNil(t, connection) | ||
| AssertErrorMessageContains(t, err, "unsupported version 1.0") | ||
| AssertTrue(t, connectionDelegate.Closed) | ||
| }) | ||
|
|
||
| outer.Run("closes connection if Bolt handshake errors", func(t *testing.T) { | ||
| clientConnection, server := setUp(t) | ||
| go func() { | ||
| server.failAcceptingVersion() | ||
| }() | ||
| connectionDelegate := &ConnDelegate{Delegate: clientConnection} | ||
| connector := &connector.Connector{SupplyConnection: supplyThis(connectionDelegate), SkipEncryption: true} | ||
|
|
||
| connection, err := connector.Connect("irrelevant", nil) | ||
|
|
||
| AssertNil(t, connection) | ||
| AssertError(t, err) | ||
| AssertTrue(t, connectionDelegate.Closed) | ||
| }) | ||
| } | ||
|
|
||
| func setUp(t *testing.T) (net.Conn, *boltHandshakeServer) { | ||
| listener, err := net.Listen("tcp", ":0") | ||
| if err != nil { | ||
| t.Fatalf("Unable to listen: %s", err) | ||
| } | ||
| t.Cleanup(func() { | ||
| _ = listener.Close() | ||
| }) | ||
|
|
||
| address := listener.Addr() | ||
| clientConnection, err := net.Dial(address.Network(), address.String()) | ||
| if err != nil { | ||
| t.Fatalf("Dial error: %s", err) | ||
| } | ||
| t.Cleanup(func() { | ||
| _ = clientConnection.Close() | ||
| }) | ||
| serverConnection, err := listener.Accept() | ||
| if err != nil { | ||
| t.Fatalf("Accept error: %s", err) | ||
| } | ||
| t.Cleanup(func() { | ||
| _ = serverConnection.Close() | ||
| }) | ||
| handshakeServer := &boltHandshakeServer{t, serverConnection} | ||
| return clientConnection, handshakeServer | ||
| } | ||
|
|
||
| func supplyThis(connection net.Conn) func(address string) (net.Conn, error) { | ||
| return func(address string) (net.Conn, error) { | ||
| return connection, nil | ||
| } | ||
| } | ||
|
|
||
| type boltHandshakeServer struct { | ||
| t *testing.T | ||
| conn net.Conn | ||
| } | ||
|
|
||
| func (server *boltHandshakeServer) waitForHandshake() []byte { | ||
| handshake := make([]byte, 4*5) | ||
| if _, err := io.ReadFull(server.conn, handshake); err != nil { | ||
| server.t.Fatalf("Unable to read client versions: %s", err) | ||
| } | ||
| return handshake | ||
| } | ||
|
|
||
| func (server *boltHandshakeServer) acceptVersion(major, minor byte) { | ||
| server.waitForHandshake() | ||
| if _, err := server.conn.Write([]byte{0x00, 0x00, minor, major}); err != nil { | ||
| panic(err) | ||
| } | ||
| } | ||
|
|
||
| func (server *boltHandshakeServer) failAcceptingVersion() { | ||
| _ = server.conn.Close() | ||
| } | ||
|
|
||
| type ConnDelegate struct { | ||
| Closed bool | ||
| Delegate net.Conn | ||
| } | ||
|
|
||
| func (cd *ConnDelegate) Read(b []byte) (n int, err error) { | ||
| return cd.Delegate.Read(b) | ||
| } | ||
|
|
||
| func (cd *ConnDelegate) Write(b []byte) (n int, err error) { | ||
| return cd.Delegate.Write(b) | ||
| } | ||
|
|
||
| func (cd *ConnDelegate) Close() error { | ||
| cd.Closed = true | ||
| return cd.Delegate.Close() | ||
| } | ||
|
|
||
| func (cd *ConnDelegate) LocalAddr() net.Addr { | ||
| return cd.Delegate.LocalAddr() | ||
| } | ||
|
|
||
| func (cd *ConnDelegate) RemoteAddr() net.Addr { | ||
| return cd.Delegate.RemoteAddr() | ||
| } | ||
|
|
||
| func (cd *ConnDelegate) SetDeadline(t time.Time) error { | ||
| return cd.Delegate.SetDeadline(t) | ||
| } | ||
|
|
||
| func (cd *ConnDelegate) SetReadDeadline(t time.Time) error { | ||
| return cd.Delegate.SetReadDeadline(t) | ||
| } | ||
|
|
||
| func (cd *ConnDelegate) SetWriteDeadline(t time.Time) error { | ||
| return cd.Delegate.SetWriteDeadline(t) | ||
| } |