Fix nil pointer errors on unit test failure (#605)

Signed-off-by: Steve Cathcart <[email protected]>
neo4j · Oct 4, 2024 · 54c9d19 · 54c9d19
1 parent 5ebc91d
commit 54c9d19
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/neo4j/internal/bolt/bolt3server_test.go b/neo4j/internal/bolt/bolt3server_test.go
@@ -47,6 +47,12 @@ func newBolt3Server(conn net.Conn) *bolt3server {
 		out: &outgoing{
 			chunker: newChunker(),
 			packer:  packstream.Packer{},
+			onPackErr: func(err error) {
+				panic(err)
+			},
+			onIoErr: func(_ context.Context, err error) {
+				panic(err)
+			},
 		},
 		reader: racing.NewRacingReader(bufio.NewReaderSize(conn, DefaultReadBufferSize)),
 	}
@@ -221,6 +227,7 @@ func setupBolt3Pipe(t *testing.T) (net.Conn, *bolt3server, func()) {
 	}
 
 	addr := l.Addr()
+	fmt.Println("Test server listening on", addr.String())
 	clientConn, _ := net.Dial(addr.Network(), addr.String())
 
 	srvConn, err := l.Accept()

diff --git a/neo4j/internal/bolt/bolt4server_test.go b/neo4j/internal/bolt/bolt4server_test.go
@@ -45,6 +45,12 @@ func newBolt4Server(conn net.Conn) *bolt4server {
 		out: &outgoing{
 			chunker: newChunker(),
 			packer:  packstream.Packer{},
+			onPackErr: func(err error) {
+				panic(err)
+			},
+			onIoErr: func(_ context.Context, err error) {
+				panic(err)
+			},
 		},
 	}
 }
@@ -292,6 +298,7 @@ func setupBolt4Pipe(t *testing.T) (net.Conn, *bolt4server, func()) {
 	}
 
 	addr := l.Addr()
+	fmt.Println("Test server listening on", addr.String())
 	clientConn, _ := net.Dial(addr.Network(), addr.String())
 
 	srvConn, err := l.Accept()

diff --git a/neo4j/internal/bolt/bolt5server_test.go b/neo4j/internal/bolt/bolt5server_test.go
@@ -44,6 +44,12 @@ func newBolt5Server(conn net.Conn) *bolt5server {
 		out: &outgoing{
 			chunker: newChunker(),
 			packer:  packstream.Packer{},
+			onPackErr: func(err error) {
+				panic(err)
+			},
+			onIoErr: func(_ context.Context, err error) {
+				panic(err)
+			},
 		},
 	}
 }
@@ -313,6 +319,7 @@ func setupBolt5Pipe(t *testing.T) (net.Conn, *bolt5server, func()) {
 	}
 
 	addr := l.Addr()
+	fmt.Println("Test server listening on", addr.String())
 	clientConn, _ := net.Dial(addr.Network(), addr.String())
 
 	srvConn, err := l.Accept()