Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #235

Merged
merged 13 commits into from
Jan 6, 2025
Merged

Improve logging #235

merged 13 commits into from
Jan 6, 2025

Conversation

stellasia
Copy link
Contributor

@stellasia stellasia commented Dec 13, 2024

Description

Truncate long lists and strings in logs. The max length of list of string is configurable using env vars.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Complexity: Low

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@stellasia stellasia force-pushed the fix/debuging-exprience branch from 80b0647 to e4342e8 Compare January 2, 2025 17:35
@stellasia stellasia changed the title WIP: improve logging Improve logging Jan 3, 2025
@stellasia stellasia marked this pull request as ready for review January 3, 2025 10:12
@stellasia stellasia requested a review from a team as a code owner January 3, 2025 10:12
src/neo4j_graphrag/experimental/pipeline/config/runner.py Outdated Show resolved Hide resolved
src/neo4j_graphrag/utils/logging.py Outdated Show resolved Hide resolved
src/neo4j_graphrag/utils/logging.py Outdated Show resolved Hide resolved
@stellasia stellasia requested a review from alexthomas93 January 6, 2025 12:36
Copy link
Contributor

@alexthomas93 alexthomas93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work on tests!

@stellasia stellasia merged commit feeddbb into neo4j:main Jan 6, 2025
7 checks passed
@stellasia stellasia deleted the fix/debuging-exprience branch January 6, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants