Add examples for LLM message history and system instruction features #240
+74
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonbesga
reviewed
Jan 6, 2025
| @@ -119,14 +119,15 @@ def invoke( | |||
| Returns: | |||
| LLMResponse: The response from the LLM. | |||
| """ | |||
| system_message = ( | |||
| system_instruction = ( | |||
There was a problem hiding this comment.
What about?
system_instruction = system_instruction or self.system_instruction
(Just a suggestion, not really important)
alexthomas93
reviewed
Jan 6, 2025
| for question in questions: | ||
| res: LLMResponse = llm.invoke( | ||
| question, | ||
| message_history=history, |
There was a problem hiding this comment.
Does message_history work with the GraphRAG class? Could be worth including an example for that if so
There was a problem hiding this comment.
Yes, using it with GraphRAG search() was the main intention.
There was a problem hiding this comment.
But I guess both examples are relevant.
| @@ -119,14 +119,15 @@ def invoke( | |||
| Returns: | |||
| LLMResponse: The response from the LLM. | |||
| """ | |||
| system_message = ( | |||
There was a problem hiding this comment.
Don't forget to make the same changes to ainvoke() 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):