-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make javafml the default loader and default to version range * #246
Comments
Good idea! I approve |
Allthough I kind of support the idea, having the different loaders actually indicate something different was IMHO the better solution. I can understand the idea, but I would personally argue: Having a Java FML mod without a single entrypoint, is an invalid construct. Then again that would create a problem with Client only Mods, which IMHO should not have been handled in the @mod, but in the TOML in the first place like it is in FMJ. Regardless if we continue going down this road: Delete the LowCode entirely, and indeed make the Java Loader the Default if not specified. |
An entrypoint can often be |
I've added a new RFC to deprecate lowcode for removal since you are correct. For people who want to make their datapack content a mod, it'd be easier to just drop the loader/loaderversion from their mod metadata going forward. |
That seems backwards in my opinion. Those annotations should be either located via ASD, or via a custom ModLocator. Piggybacking on JavaFML seems at least not pass the sniff-test in my opinion. At least that is as long as there is a mod locator that loads libraries, because then the ASB tracking will work. Besides that i have never seen any of those entry points without an actual @mod, so I am not sure what I should think of that argument. |
Entrypoint is really the wrong name, I think. IMHO all of those are valid, since we relaxed the requirement. For modders that seems really convenient! |
There is no need for a Mod entrypoint if all your mod needs to do is to kill every player that damages an entity, as that's just an event subscriber. Obviously this example is a bit far-fetched but the point still stands, a lot of mods compose their entrypoint of just adding event listeners, which they can replace with EBS. Additionally, as can be seen here at least 9 mods on 1.21.1 use EBS without a |
Since making entrypoints in fmljava mods optional, it can be used to make resource-only mods without having to switch the loader to the lowcode loader.
To reduce modder confusion and ease of use, I propose that we:
"*"
since the FML version is already controlled through the dependency onneoforge
The text was updated successfully, but these errors were encountered: