Add OpenGL state tracking #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last commit published: dbe87772142f25b10b547c7e0d2890b42a73c9a7. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #255' // https://github.com/neoforged/FancyModLoader/pull/255
url 'https://prmaven.neoforged.net/FancyModLoader/pr255'
content {
includeModule('net.neoforged.fancymodloader', 'earlydisplay')
includeModule('net.neoforged.fancymodloader', 'junit-fml')
includeModule('net.neoforged.fancymodloader', 'loader')
includeModule('net.neoforged.fancymodloader', 'tests')
}
}
} |
…rendering EarlyDisplay
shartte
force-pushed
the
gl-state-tracking
branch
from
5223a6d to
ad781ea
Compare
…rendering EarlyDisplay
marchermans
approved these changes
Mar 2, 2025
|
🚀 This PR has been released as FancyModLoader version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EarlyDisplay has to update its loading screen framebuffer interleaved with OpenGL rendering done by Vanilla (this happens during the cross-fade between the two).
Vanilla in 1.21.5 starts aggressively caching OpenGL state in various places, making it difficult if the external rendering by EarlyDisplay leaves the context in a state different from when it started. To fix this, I introduced a state tracker that is able to initialize itself from the current OpenGL pipeline state to restore it when EarlyDisplay is done.