Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.3] RegisterRenderStateModifiersEvent for appending custom data to render state objects #1650

Open
wants to merge 49 commits into
base: 1.21.x
Choose a base branch
from
Open

[1.21.3] RegisterRenderStateModifiersEvent for appending custom data to render state objects #1650

wants to merge 49 commits into from

Commits on Nov 11, 2024

  1. Draft for event

    @dhyces
    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fab1b31 View commit details
    Browse the repository at this point in the history

  2. Example 1

    @dhyces
    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3139c92 View commit details
    Browse the repository at this point in the history

  3. Example 2

    @dhyces
    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3c5e760 View commit details
    Browse the repository at this point in the history

  4. Cherry-pick changes from example 2 branch

    @dhyces
    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    99600ad View commit details
    Browse the repository at this point in the history

  5. Apply Tslat's feedback 

    1. Moved callsite to `createRenderState`. This differs from feedback, though I believe is a better location, seeing as the method is final and will apply modifiers if users call the method.
2. Some classes have been renamed to better reflect behavior
3. Use ContextKey instead of custom class
4. Retain each modifier separately so that subclasses may be considered
5. Use lazily evaluated map for storing all modifiers that apply to a given renderer
    @dhyces
    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f98e132 View commit details
    Browse the repository at this point in the history

  6. Rename to RegisterRenderStateModifiersEvent

    @dhyces
    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a8ef1cf View commit details
    Browse the repository at this point in the history

  7. Spotless

    @dhyces
    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    b41cdf4 View commit details
    Browse the repository at this point in the history

  8. Use appropriate class from the entry

    @dhyces
    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    9691504 View commit details
    Browse the repository at this point in the history

  9. Reset render data before computing modifiers

    @dhyces
    dhyces committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    b519839 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Update EntityRenderState.java.patch

    @dhyces
    dhyces committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    8643b7d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Remove lazy map init

    @dhyces
    dhyces committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    48db639 View commit details
    Browse the repository at this point in the history

  2. Merge branch '1.21.x' into feat/render-state-event

    @dhyces
    dhyces authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    84dacf3 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Merge branch '1.21.x' into feat/render-state-event

    @dhyces
    dhyces authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ea86bb1 View commit details
    Browse the repository at this point in the history

  2. Update with proposed changes and add jdocs

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c79f020 View commit details
    Browse the repository at this point in the history

  3. Spotless

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d6f6d5e View commit details
    Browse the repository at this point in the history

  4. Remove rather unnecessary interface indirection

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    162cc71 View commit details
    Browse the repository at this point in the history

  5. Missed patch generation

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2ff63e8 View commit details
    Browse the repository at this point in the history

  6. Fix entity render states

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    bc9fec4 View commit details
    Browse the repository at this point in the history

  7. Fail instead of throw

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    432b640 View commit details
    Browse the repository at this point in the history

  8. Add another fail condition

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d15a61d View commit details
    Browse the repository at this point in the history

  9. Add map render state modifiers

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0548610 View commit details
    Browse the repository at this point in the history

  10. Spotless

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ec1d9fb View commit details
    Browse the repository at this point in the history

  11. Inline 

    Forgot I had removed the rest of the method
    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    07abe9f View commit details
    Browse the repository at this point in the history

  12. Move some classes to specific package

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9a70d17 View commit details
    Browse the repository at this point in the history

  13. Split out MapDecorationRenderStateModifier

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    fb09e53 View commit details
    Browse the repository at this point in the history

  14. Add override annotations

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    346fc0b View commit details
    Browse the repository at this point in the history

  15. Move update methods into RenderStateExtensions

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ed942c8 View commit details
    Browse the repository at this point in the history

  16. Move event into subpackage and reduce method vis

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3fbf679 View commit details
    Browse the repository at this point in the history

  17. Apply formatting

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3194e3a View commit details
    Browse the repository at this point in the history

  18. Generate patches

    @dhyces
    dhyces committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8ad9a50 View commit details
    Browse the repository at this point in the history

  19. Merge branch '1.21.x' into feat/render-state-event

    @dhyces
    dhyces authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c1c76b8 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Docs changes

    @dhyces
    dhyces committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    075db02 View commit details
    Browse the repository at this point in the history

  2. Simplify RenderStateExtensions

    @dhyces
    dhyces committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4c44bf2 View commit details
    Browse the repository at this point in the history

  3. Fix flipped method call

    @dhyces
    dhyces committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    cdf43f7 View commit details
    Browse the repository at this point in the history

  4. Update docs

    @dhyces
    dhyces committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    169c0d3 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Add living entity register method 

    Acts as an example for users
    @dhyces
    dhyces committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    67d86e6 View commit details
    Browse the repository at this point in the history

  2. Some more jdoc changes

    @dhyces
    dhyces committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1e24034 View commit details
    Browse the repository at this point in the history

  3. Update to using TypeTokens

    @dhyces
    dhyces committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    6e0cca3 View commit details
    Browse the repository at this point in the history

  4. Apply formatting

    @dhyces
    dhyces committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e057759 View commit details
    Browse the repository at this point in the history

  5. Adjust test scaling

    @dhyces
    dhyces committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    532ced9 View commit details
    Browse the repository at this point in the history

  6. Remove redundant cast

    @dhyces
    dhyces committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1332b90 View commit details
    Browse the repository at this point in the history

  7. Work on runtime type safety checks 

    Not at all finished
    @dhyces
    dhyces committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b429629 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Adjust type safety (big thanks to @lukebemish)

    @dhyces
    dhyces committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    1f34a18 View commit details
    Browse the repository at this point in the history

  2. Example usage docs

    @dhyces
    dhyces committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    dc0bba0 View commit details
    Browse the repository at this point in the history

  3. Convenience method

    @dhyces
    dhyces committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7f2e7fc View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. Update test

    @dhyces
    dhyces committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    e00f760 View commit details
    Browse the repository at this point in the history

  2. Merge branch '1.21.x' into feat/render-state-event

    @dhyces
    dhyces authored Nov 23, 2024
    Configuration menu
    Copy the full SHA
    54a5d6a View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2024

  1. Apply feedback

    @dhyces
    dhyces committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    623bb3f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feat/render-state-event' of https://github.com/dhyces/N… 

    …eoForge into feat/render-state-event
    @dhyces
    dhyces committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    d400b27 View commit details
    Browse the repository at this point in the history