-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency org.slf4j:slf4j-api to v2.0.16 (1.21.x) #1870
base: 1.21.x
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mojang uses SLF4J 2.0.16 (see piston-meta), we should not downgrade it.
Can you first check that we are actually downgrading? The NeoForm dependencies should be strict. |
Of course I don't object to the bump, but we should check that there is no silent downgrading. 😉 |
We indeed are (from a profile)
|
Hmm hold on, that's a 1.21.1 profile whoops. Well considering the same version is in neo in 1.21.1 but the mojang version is used in the profile I suppose we aren't downgrading it. I'll still check, tho it's better if we use the correct version anyway (we could also just not touch slf4j in neo...) |
After looking further into this, that's the compile only slf4j version used by the coremods project. That's confusing and not very ideal... I'll work towards publishing a bom in the gradle mc deps project so we can add that dependency while using the version mojang ships. |
This PR contains the following updates:
2.0.7
->2.0.16
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.