Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency org.slf4j:slf4j-api to v2.0.16 (1.21.x) #1870

Open
wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from

Conversation

neoforged-renovate[bot]
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
org.slf4j:slf4j-api (source, changelog) dependencies patch 2.0.7 -> 2.0.16

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@neoforged-renovate neoforged-renovate bot added the dependencies Dependency updates label Jan 18, 2025
@neoforged-automation neoforged-automation bot added the 1.21.4 Targeted at Minecraft 1.21.4 label Jan 18, 2025
@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

Copy link
Member

@Matyrobbrt Matyrobbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mojang uses SLF4J 2.0.16 (see piston-meta), we should not downgrade it.

@Matyrobbrt Matyrobbrt enabled auto-merge (squash) January 18, 2025 09:02
@Technici4n
Copy link
Member

Can you first check that we are actually downgrading? The NeoForm dependencies should be strict.

@Technici4n
Copy link
Member

Of course I don't object to the bump, but we should check that there is no silent downgrading. 😉

@Technici4n Technici4n disabled auto-merge January 18, 2025 09:04
@Matyrobbrt
Copy link
Member

We indeed are (from a profile)

{"name":"org.slf4j:slf4j-api:2.0.9","url":null,"serverreq":null,"clientreq":null,"natives":null,"extract":null,"rules":null,"downloads":{"artifact":{"path":"org/slf4j/slf4j-api/2.0.9/slf4j-api-2.0.9.jar","url":"https://libraries.minecraft.net/org/slf4j/slf4j-api/2.0.9/slf4j-api-2.0.9.jar","sha1":"7cf2726fdcfbc8610f9a71fb3ed639871f315340","size":64579},"classifiers":null}}

@Matyrobbrt
Copy link
Member

Hmm hold on, that's a 1.21.1 profile whoops. Well considering the same version is in neo in 1.21.1 but the mojang version is used in the profile I suppose we aren't downgrading it. I'll still check, tho it's better if we use the correct version anyway (we could also just not touch slf4j in neo...)

@Matyrobbrt
Copy link
Member

After looking further into this, that's the compile only slf4j version used by the coremods project. That's confusing and not very ideal... I'll work towards publishing a bom in the gradle mc deps project so we can add that dependency while using the version mojang ships.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 dependencies Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants