Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the minecraft-dependencies BOM for deps #1872

Open
wants to merge 6 commits into
base: 1.21.x
Choose a base branch
from

Conversation

Matyrobbrt
Copy link
Member

@Matyrobbrt Matyrobbrt commented Jan 18, 2025

This PR switches us from using a version of GSON and SLF4J defined in the gradle.properties for the coremods and Gradle plugin projects to using the minecraft-dependencies platform to keep the versions in sync.

The PR also removes the explicit commons-lang3 dependency as the server and client version difference is no longer present in 1.21.4

@Matyrobbrt Matyrobbrt added ci/build Related to continuous integration/build system 1.21.4 Targeted at Minecraft 1.21.4 labels Jan 18, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 18, 2025

  • Publish PR to GitHub Packages

Last commit published: 01136d0bac627a522d163d5f1d0ca6d20c7bb71f.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1872' // https://github.com/neoforged/NeoForge/pull/1872
        url 'https://prmaven.neoforged.net/NeoForge/pr1872'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1872.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1872
cd NeoForge-pr1872
curl -L https://prmaven.neoforged.net/NeoForge/pr1872/net/neoforged/neoforge/21.4.72-beta-pr-1872-use-bom-for-deps/mdk-pr1872.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

buildSrc/build.gradle Outdated Show resolved Hide resolved
buildSrc/build.gradle Outdated Show resolved Hide resolved
@Matyrobbrt Matyrobbrt requested a review from shartte January 18, 2025 16:44
shartte
shartte previously approved these changes Jan 18, 2025
@neoforged-automation
Copy link

@Matyrobbrt, this pull request has conflicts, please resolve them for this PR to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 ci/build Related to continuous integration/build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants