Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the usages of List.of and Map.of #264

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Remove the usages of List.of and Map.of #264

merged 3 commits into from
Mar 4, 2025

Conversation

marchermans
Copy link
Contributor

TLDR:

Gradle is stupid.

Changes:

  • Wrap all usages of List.of(...) in Lists.newArrayList(...)
  • Wrap all usages of Map.of(...) in Maps.newHashMap(...)

Potentially through some delegate wrapper.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Mar 4, 2025

  • Publish PR to GitHub Packages

Last commit published: 3a42f0ea96a0120fd4e53aef44db98366e307219.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #264' // https://github.com/neoforged/NeoGradle/pull/264
        url 'https://prmaven.neoforged.net/NeoGradle/pr264'
        content {
            includeModule('net.neoforged.gradle', 'common')
            includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-common')
            includeModule('net.neoforged.gradle', 'dsl-mixin')
            includeModule('net.neoforged.gradle', 'dsl-neoform')
            includeModule('net.neoforged.gradle', 'dsl-platform')
            includeModule('net.neoforged.gradle', 'dsl-userdev')
            includeModule('net.neoforged.gradle', 'dsl-vanilla')
            includeModule('net.neoforged.gradle', 'mixin')
            includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
            includeModule('net.neoforged.gradle', 'neoform')
            includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'platform')
            includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'test-utils')
            includeModule('net.neoforged.gradle', 'userdev')
            includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
            includeModule('net.neoforged.gradle', 'utils')
            includeModule('net.neoforged.gradle', 'vanilla')
            includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
        }
    }
}

@marchermans marchermans merged commit 896cae3 into NG_7.0 Mar 4, 2025
67 of 75 checks passed
@marchermans marchermans deleted the fix/list_of branch March 4, 2025 15:02
@neoforged-releases
Copy link

🚀 This PR has been released as NeoGradle version 7.0.182.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant