Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Changes #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Minor Changes #4

wants to merge 2 commits into from

Conversation

NadaaFarook
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Feb 2, 2022

❌ Deploy Preview for mockman-js failed.

🔨 Explore the source changes: fb73e1d

🔍 Inspect the deploy log: https://app.netlify.com/sites/mockman-js/deploys/61fad163a34d33000894c39e

Copy link
Contributor

@sohamsshah sohamsshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you add docs for the newly added features in README?
Yup

@sohamsshah
Copy link
Contributor

Hi @NadaaFarook , is it good to be merged?

Copy link
Contributor

@sohamsshah sohamsshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the doc? Minimal readme changes would be good to go.

@@ -19,13 +19,18 @@ const InputResponse = ({ data }) => {
<div>
<h3 className="title">Response: </h3>
<ReactJson
theme={colorScheme == "dark" && "threezerotwofour"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is "threezerotwofour"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants