Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video_saved signal noop when raw #35

Closed
wants to merge 1 commit into from
Closed

video_saved signal noop when raw #35

wants to merge 1 commit into from

Conversation

mrname
Copy link

@mrname mrname commented Jun 28, 2019

Resolves #34

@mrname
Copy link
Author

mrname commented Jun 28, 2019

FYI on the CI checks, it is only flake8 that is failing, not the tests. Happy to fix the flake8 violations as well, but did not want to lump it into this functionality change.

@seb-b
Copy link
Member

seb-b commented Jul 4, 2019

@mrname Looking good!.

If you could fix the flake8 errors caused by these changes that would be good. The one in the chooser.py and the other in test/storage.py are caused by updates to flake8 and I can fix those by updating the .flake8 config

Otherwsie looks like there's some unused imports in tests/test_model.py with some extra blank lines and an isort error as well.

@seb-b seb-b closed this Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

video_saved signal does not check for the raw keyword
2 participants
@mrname @seb-b