Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): skip repartition if we need L0 compaction #10547

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jan 28, 2025

Problem

Repartition is slow, but it's only used in image layer creation. We can skip it if we have a lot of L0 layers to ingest.

Summary of changes

If L0 compaction is not complete, do not repartition and do not create image layers.

@skyzh skyzh requested a review from erikgrinaker January 28, 2025 19:43
@skyzh skyzh requested a review from a team as a code owner January 28, 2025 19:43
Copy link

github-actions bot commented Jan 28, 2025

7414 tests run: 7062 passed, 0 failed, 352 skipped (full report)


Flaky tests (7)

Postgres 17

Postgres 16

Code coverage* (full report)

  • functions: 33.3% (8495 of 25482 functions)
  • lines: 49.1% (71413 of 145486 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
eeebfd1 at 2025-01-29T21:42:09.235Z :recycle:

pageserver/src/tenant/timeline/compaction.rs Show resolved Hide resolved
pageserver/src/tenant/timeline/compaction.rs Outdated Show resolved Hide resolved
pageserver/src/tenant/timeline/compaction.rs Outdated Show resolved Hide resolved
@skyzh skyzh enabled auto-merge January 29, 2025 16:11
@skyzh skyzh force-pushed the skyzh/skip-repartition branch from 6b89553 to eeebfd1 Compare January 29, 2025 20:09
@skyzh skyzh added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 9dff6cc Jan 29, 2025
80 checks passed
@skyzh skyzh deleted the skyzh/skip-repartition branch January 29, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants