Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): use the larger one of upper limit and threshold #10571

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jan 29, 2025

Problem

Follow up of #10550 in case the upper limit is set larger than threshold. It does not make sense for someone to enforce the behavior like "if there are >= 50 L0s, only compact 10 of them".

Summary of changes

Use the maximum of compaction threshold and upper limit when selecting L0 files to compact.

@skyzh skyzh requested a review from a team as a code owner January 29, 2025 19:18
Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't caused problems, right? Because the default upper limit is larger than default threshold ?

@skyzh
Copy link
Member Author

skyzh commented Jan 29, 2025

Yes, but we set the threshold for some tenants in prod to 100/300, which is larger than the default upper limit 50.

Copy link

github-actions bot commented Jan 29, 2025

7414 tests run: 7063 passed, 0 failed, 351 skipped (full report)


Flaky tests (8)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 33.4% (8506 of 25499 functions)
  • lines: 49.1% (71460 of 145505 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
c3da34e at 2025-01-30T00:15:26.880Z :recycle:

@skyzh skyzh force-pushed the skyzh/uppser-bound-threshold branch from 92056c5 to c3da34e Compare January 29, 2025 21:28
@skyzh skyzh enabled auto-merge January 29, 2025 21:37
@skyzh skyzh added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 77ea9b1 Jan 30, 2025
80 checks passed
@skyzh skyzh deleted the skyzh/uppser-bound-threshold branch January 30, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants