unify pg-build-nonroot-with-cargo base layer and config retries in curl #10575
+19
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7414 tests run: 7062 passed, 0 failed, 352 skipped (full report)Flaky tests (6)Postgres 17
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
194092b at 2025-01-30T15:04:33.025Z :recycle: |
myrrc
requested changes
Jan 30, 2025
compute/compute-node.Dockerfile
Outdated
Comment on lines
1280
to
1281
| RUN echo -e "--retry-connrefused\n--connect-timeout 15\n--retry 5\n--max-time 300\n" > /root/.curlrc | ||
| RUN if [ "$TARGETARCH" = "amd64" ]; then\ |
There was a problem hiding this comment.
Can you stack it with the next command please to avoid creating extra layer?
There was a problem hiding this comment.
thanks for pointing, fixed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/neondatabase/cloud/issues/23461
Problem
Just made changes around and see these 2 base layers could be optimised.
and after review comment from @myrrc setting up timeouts and retries in
alpine/curlimageSummary of changes