Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: make control_plane_api & generations fully mandatory #10715

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Feb 7, 2025

Problem

We had retained the ability to run in a generation-less mode to support test_generations_upgrade, which was replaced with a cleaner backward compat test in #10701

Summary of changes

  • Remove all the special cases for "if no generation" or "if no control plane api"
  • Make control_plane_api config mandatory

@jcsp jcsp changed the title Jcsp/generations ptn pageserver: make control_plane_api & generations fully mandator Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

7425 tests run: 7067 passed, 0 failed, 358 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 33.3% (8585 of 25819 functions)
  • lines: 49.1% (72287 of 147221 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
814f47b at 2025-02-07T14:50:36.257Z :recycle:

@jcsp jcsp force-pushed the jcsp/generations-ptn branch from e338463 to 5971771 Compare February 7, 2025 11:06
@jcsp jcsp changed the title pageserver: make control_plane_api & generations fully mandator pageserver: make control_plane_api & generations fully mandatory Feb 7, 2025
@jcsp jcsp force-pushed the jcsp/generations-ptn branch from 5971771 to 814f47b Compare February 7, 2025 13:45
@jcsp
Copy link
Collaborator Author

jcsp commented Feb 7, 2025

docker-compose.yml was still relying on creating a pageserver with no config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant