-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove aws-lc-rs dep and fix storage_broker tls #9613
Conversation
5328 tests run: 5106 passed, 0 failed, 222 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
e513e6f at 2024-11-04T13:21:59.015Z :recycle: |
I've also opened hyperium/tonic#2034 as more robust solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please, for a different reason: I just bumped into this issue compiling with cranelift: rust-lang/rustc_codegen_cranelift#1520. I'm sure that'll be eventually fixed, but not using aws-lc-rs avoids it.
Do we need to specify a provider at all? How about using https://docs.rs/rustls/latest/rustls/server/struct.ServerConfig.html#method.builder instead?
The pg17 failures do not seem to be flaky. I'm not sure what's changed there |
a07cbad
to
e513e6f
Compare
It seems the ecosystem is not so keen on moving to aws-lc-rs as it's build setup is more complicated than ring (requiring cmake).
Eventually I expect the ecosystem should pivot to https://github.com/ctz/graviola/tree/main/rustls-graviola as it stabilises (it has a very simply build step and license), but for now let's try not have a headache of juggling two crypto libs.
I also noticed that tonic will just fail with tls without a default provider, so I added some defensive code for that.