-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Column spacing and missing bold font #461
base: main
Are you sure you want to change the base?
BUGFIX: Column spacing and missing bold font #461
Conversation
Thx! Looks good by reading but will test it locally. I updated the title as its more like a bugfix and should be more precise. |
Thanks! 💙 Yes, in hindsight you are right. I updated also the description above |
DistributionPackages/Neos.NeosIo/Resources/Private/Scss/_Framework/_Fonts.scss
Show resolved
Hide resolved
DistributionPackages/Neos.NeosIo/Resources/Private/Scss/Utilities/_Neos.scss
Show resolved
Hide resolved
@@ -79,6 +79,7 @@ | |||
margin-bottom: $half-spacing+px; | |||
font-size: $base-font-size*1.3px; | |||
line-height: $base-line-height*1px; | |||
font-weight: $regular; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not necessary. We need to adjust the base mixin h()
to use $regular
. Additionally you can remove the font-weight
overrides in the mixins h5
and h6
as they would break the current website styling.
You can check the impact of this change e.g. on the schedule page of the NEOSCON.
fa3bd92
to
3d6bdd5
Compare
@crydotsnake did you implement all requested changes by @ahaeslich |
Sadly not. Unfortunately I have totally lost sight of that |
@Sebobo is this MR still relevant regarding that you are working on the website right now? |
@ahaeslich it will have some conflicts as I resolved the font problem with a variable font type, but I didn't touch the spacing part. So rebasing and targeting the development branch would be best. |
This pull request provides a few bugfixes for the Neos website. Previously it was not possible to mark text as Bold in the word processor, because the required font file was not loaded. I went through the layout afterwards, and everywhere where the text was Bold afterwards (like in the navigation) I set the
font-weight
toregular
, so the layout wouldn't break. Also, in the text with image element, there was no space between the image and the text when I placed the image either on the left, or right side. I also added a small space between the text and the icon in the ImageTeaser, so that it doesn't look so squeezed on top of each other. But I have summarized my changes in screenshots.Before Screenshots
After Screenshots