BUGFIX: remove nodes from index on discard

[dimaip]

Discarding a node does not emit nodeRemoved, so we should list for nodeDiscarded additionally.

Steps to reproduce:

1. Create a new document node
2. Discard it right away
3. Observe that the node remains in ES index (it will be thrown away on conversion to Node results, but you may search for it manually in ES index).

[kdambekalns]

I did not test this, but after a short discussion with @robertlemke I veto this… I was confused as to why discarding a node does not trigger nodeRemoved, since it removes the node from some workspace…

But a discard operation is not removing that added node, but undoing the addition.

That is what makes this change (probably) dangerous: A discard signal could also mean some removal was discarded, or just a change to some property. Handling that all in removeNode() would lead to very unexpected results…

[dimaip]

@kdambekalns look at the code here: https://github.com/neos/neos-development-collection/blob/2dd65a83c73c9dba7c61f7542dd17eb8a0511dd4/Neos.ContentRepository/Classes/Domain/Service/PublishingService.php#L198

Are you sure that by this point it does anything else besides removing a node?

Anyways, will take a closer look and try to reproduce what you are saying, but if someone with more experience in this area wants to take over, that'd be cool.

[kdambekalns]

Not sure, no. As I said, I didn't test. That removal is handling NodeData, not Node, but… it would be correct, if all discard operations end up removing the node from the corresponding workspace.

But the index update might still need to be doing something else than "remove". Because if a removal or change is discarded, removing the data from the index of my workspace would not be correct.

[kdambekalns]

Doh, that's old by now… Does someone feel like investigating the current state?