TASK: Add indexing configuration for type DateTime #30
Conversation
kdambekalns
changed the title
| @@ -14,6 +14,8 @@ Neos: | |||
| indexing: '${value}' | |||
| date: | |||
| indexing: '${(value ? Date.format(value, ''Y-m-d\TH:i:s'') + ''Z'' : null)}' | |||
| DateTime: | |||
There was a problem hiding this comment.
Does that work with DateTimeInterface? Then it would be universal…
There was a problem hiding this comment.
Not sure, but in doubt we can just configure both?
| @@ -14,6 +14,8 @@ Neos: | |||
| indexing: '${value}' | |||
| date: | |||
There was a problem hiding this comment.
Could date be removed then? TBH I don't understand why that used to work, date never was a valid type in PHP land…
There was a problem hiding this comment.
Not sure, did we ever deprecate it, does it still work to use it? We manually map it somewhere... Why ever we did that.
We should also take care (probably next version though) to deprecate reference and references and make it Node and array
There was a problem hiding this comment.
NVM that, doesn't really belong here. I thought this was a change in Neos.
| @@ -14,6 +14,8 @@ Neos: | |||
| indexing: '${value}' | |||
| date: | |||
| indexing: '${(value ? Date.format(value, ''Y-m-d\TH:i:s'') + ''Z'' : null)}' | |||
| DateTime: | |||
There was a problem hiding this comment.
Not sure, but in doubt we can just configure both?
| @@ -14,6 +14,8 @@ Neos: | |||
| indexing: '${value}' | |||
| date: | |||
There was a problem hiding this comment.
Not sure, did we ever deprecate it, does it still work to use it? We manually map it somewhere... Why ever we did that.
We should also take care (probably next version though) to deprecate reference and references and make it Node and array
No description provided.